Closed
Bug 1112746
Opened 10 years ago
Closed 10 years ago
some internal object checks are missed in xpcom wrapper
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8538049 -
Flags: review?(yzen)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8538049 [details] [diff] [review] patch Review of attachment 8538049 [details] [diff] [review]: ----------------------------------------------------------------- Looks good once the comment is fixed, jsat tests pass too ::: accessible/xpcom/xpcAccessible.cpp @@ +188,5 @@ > NS_IMETHODIMP > xpcAccessible::GetRootDocument(nsIAccessibleDocument** aRootDocument) > { > NS_ENSURE_ARG_POINTER(aRootDocument); > + *aRootDocument = null; need to be nullptr
Attachment #8538049 -
Flags: review?(yzen) → review+
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/966a9342fac1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•