Closed Bug 1112746 Opened 7 years ago Closed 7 years ago

some internal object checks are missed in xpcom wrapper

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: surkov, Assigned: surkov)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8538049 - Flags: review?(yzen)
Comment on attachment 8538049 [details] [diff] [review]
patch

Review of attachment 8538049 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good once the comment is fixed, jsat tests pass too

::: accessible/xpcom/xpcAccessible.cpp
@@ +188,5 @@
>  NS_IMETHODIMP
>  xpcAccessible::GetRootDocument(nsIAccessibleDocument** aRootDocument)
>  {
>    NS_ENSURE_ARG_POINTER(aRootDocument);
> +  *aRootDocument = null;

need to be nullptr
Attachment #8538049 - Flags: review?(yzen) → review+
https://hg.mozilla.org/mozilla-central/rev/966a9342fac1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.