1112908 - [RTL][Calendar] Drawer tray and Calendar Settings do not have UI elements properly aligned/mirrored

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
In Calendar when language is RTL like Arabic, subheaders in options menu are not right-aligned, and the blue checkmark icons as well as the text in drawer tray keep alignment from LTR language format. 

According to spec, the subheaders and text should be right aligned and the blue checkmarks should be left aligned.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141217040204
2) Set language to Arabic
3) Launch Calendar
4) Tap drawer icon and observe open tray
5) Tap gear icon and observe settings screen
  
Actual:
Subheaders and text in drawer and settings menu are left aligned. Checkboxes in drawer are right aligned.
  
Expected: 
Subheaders and text in drawer and settings menu are right aligned. Checkboxes in drawer are left aligned.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141217040204
Gaia: d22dfece04fc00457e8369c660c11f945b088d2f
Gecko: cb8ad2251c09
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1112908 to mozilla-b2g:master

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8547222 [details] [review]
[PullReq] anefzaoui:bug-1112908 to mozilla-b2g:master

Please review?
Thanks!

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8547222 [details] [review]
[PullReq] anefzaoui:bug-1112908 to mozilla-b2g:master

LGTM. fixes the problem. thanks!

Comment 4

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27302

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a0d3b12121fe1609b0bfe139ad830deb51314fd9

Comment 6

[Elie]

Hi Ahmend:
This issue still exist on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Reproduce rate 5/5
Happen time   2:10
Description:Launch calendar->Tap drawer icon and observe open tray->Tap gear icon and observe settings screen,Subheaders and text in drawer and settings menu are left aligned. Checkboxes in drawer are right aligned.
Expected: 
Subheaders and text in drawer and settings menu are right aligned. Checkboxes in drawer are left aligned.
Pleaser refer to viedo VIDEO0253.mp4 and logcat.txt

Comment 7

[Elie]

Attachment: logcat.txt

Comment 8

[Elie]

Attachment: VIDEO0253.mp4

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

I'm aware of this, and it will be handled by an uplifting request.

Comment 10

[Delphine Lebédel [:delphine - Use needinfo]]

Verified the fix on Flame Master (currently 3.0) and looks good.
Nominating for 2.2 as this needs to be consistent across the phone.

Comment 11

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8547222 [details] [review]
[PullReq] anefzaoui:bug-1112908 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): lack of RTL support
[User impact] if declined: see attachment 8538163 [details]
[Testing completed]: Yes, testing device: flame
[Risk to taking this patch] (and alternatives if risky): low risk, patch changes only rtl-related css
[String changes made]: No string changes

Comment 12

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 13

[Fabien Cazenave [:kaze]]

Uplifted to 2.2: https://github.com/mozilla-b2g/gaia/commit/6a0b6f6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please don't forget to set the status flags when uplifting.

Comment 15

[Fabien Cazenave [:kaze]]

Ooops, will do.

Comment 16

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: Menu items on the drawer and settings screen are right-aligned.
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150202010229
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: 940118b1adcd
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 17

[Coler]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15240/