Closed
Bug 1112986
Opened 9 years ago
Closed 9 years ago
[Stingray][Home] Application and AppBookmark should be merged into one class
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
(Whiteboard: [ft:conndevices][Stingray-Branch])
Attachments
(1 file)
AppBookmark (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/app_bookmark.js) and Application (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/application.js) are almost the same and serve pretty much the same purpose, except that AppBookmark could designate launchURL. We should merge them into one class, by adding launchURL in to Application or something similar.
Assignee | ||
Updated•9 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Component: Gaia → Gaia::TV
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8559011 [details] [review] [PullReq] dwi2:bug1112986 to mozilla-b2g:master Hi Rex, Please help to review the patch. `AppBookmark` now is part of `Application`. Thanks
Attachment #8559011 -
Flags: review?(rexboy)
Assignee | ||
Updated•9 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][Stingray-Branch]
Comment 3•9 years ago
|
||
Comment on attachment 8559011 [details] [review] [PullReq] dwi2:bug1112986 to mozilla-b2g:master r=me with nits. See my comments before landing. Thanks!
Attachment #8559011 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/27906 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/27906 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Assignee | ||
Comment 6•9 years ago
|
||
Gaia-try is green https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=10c0c7135e41 Landed on master https://github.com/mozilla-b2g/gaia/commit/e0e552beb9fc210232e945c2266a6936901d9903
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•