1112986 - [Stingray][Home] Application and AppBookmark should be merged into one class

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

AppBookmark (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/app_bookmark.js) and Application (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/application.js) are almost the same and serve pretty much the same purpose, except that AppBookmark could designate launchURL.

We should merge them into one class, by adding launchURL in to Application or something similar.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] dwi2:bug1112986 to mozilla-b2g:master

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8559011 [details] [review]
[PullReq] dwi2:bug1112986 to mozilla-b2g:master

Hi Rex, 

Please help to review the patch. `AppBookmark` now is part of `Application`. Thanks

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8559011 [details] [review]
[PullReq] dwi2:bug1112986 to mozilla-b2g:master

r=me with nits. 
See my comments before landing. Thanks!

Comment 4

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27906

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27906

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-try is green
https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=10c0c7135e41

Landed on master
https://github.com/mozilla-b2g/gaia/commit/e0e552beb9fc210232e945c2266a6936901d9903