Closed Bug 1112986 Opened 11 years ago Closed 10 years ago

[Stingray][Home] Application and AppBookmark should be merged into one class

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][Stingray-Branch])

Attachments

(1 file)

AppBookmark (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/app_bookmark.js) and Application (https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-home/js/application.js) are almost the same and serve pretty much the same purpose, except that AppBookmark could designate launchURL. We should merge them into one class, by adding launchURL in to Application or something similar.
OS: Mac OS X → Gonk (Firefox OS)
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Component: Gaia → Gaia::TV
Comment on attachment 8559011 [details] [review] [PullReq] dwi2:bug1112986 to mozilla-b2g:master Hi Rex, Please help to review the patch. `AppBookmark` now is part of `Application`. Thanks
Attachment #8559011 - Flags: review?(rexboy)
Whiteboard: [ft:conndevices] → [ft:conndevices][Stingray-Branch]
Comment on attachment 8559011 [details] [review] [PullReq] dwi2:bug1112986 to mozilla-b2g:master r=me with nits. See my comments before landing. Thanks!
Attachment #8559011 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/27906 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/27906 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: