Closed Bug 1113073 Opened 9 years ago Closed 9 years ago

Add H264 AVCC support with 3-bytes NAL

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file, 1 obsolete file)

libstagefright converted all AVCC NAL to always be 4-bytes long.

However, the new MoofParser returns the AVCC NAL as-is.

As such, we need to re-add support for non-4-bytes NALs.
Add 2/3/4-bytes NAL Size support
Attachment #8538824 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8538824 - Flags: review?(ajones) → review+
Rebase. Check boundaries, and size offset validity
Attachment #8538824 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/015a8e5010ee
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8539778 [details] [diff] [review]
Add H264 3-bytes NAL size support

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This adds support for more files, but shouldn't affect currently working ones.
[String/UUID change made/needed]: None.
Attachment #8539778 - Flags: approval-mozilla-aurora?
Attachment #8539778 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.