1113073 - Add H264 AVCC support with 3-bytes NAL

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

libstagefright converted all AVCC NAL to always be 4-bytes long.

However, the new MoofParser returns the AVCC NAL as-is.

As such, we need to re-add support for non-4-bytes NALs.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Add H264 3-bytes NAL size support

Add 2/3/4-bytes NAL Size support

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Add H264 3-bytes NAL size support

Rebase. Check boundaries, and size offset validity

Comment 3

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/015a8e5010ee

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/015a8e5010ee

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8539778 [details] [diff] [review]
Add H264 3-bytes NAL size support

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; sites more likely to serve flash video.
[Describe test coverage new/current, TBPL]: Landed on m-c.
[Risks and why]: Low. This adds support for more files, but shouldn't affect currently working ones.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/25674b68ea1c