1113081 - Remove references to metro mode from talos.py script

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We did a lot of great work to get metro support in our product and related infrastructure.  It seems that we can clean up our code by removing this since we haven't been running metro mode for a while:
http://hg.mozilla.org/build/mozharness/file/tip/mozharness/mozilla/testing/talos.py

There is one block here:
http://hg.mozilla.org/build/mozharness/file/tip/mozharness/mozilla/testing/talos.py#l226

another here:
http://hg.mozilla.org/build/mozharness/file/tip/mozharness/mozilla/testing/talos.py#l525

and another here:
http://hg.mozilla.org/build/mozharness/file/tip/mozharness/mozilla/testing/talos.py#l593

To get started:
* clone hg.mozilla.org/build/mozharness
* make you changes and submit a patch (diff) to this bug
* run local unittests

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Armen, can you outline how to run unittests from mozharness?

Comment 2

[Armen [:armenzg]]

To run mozharness unittests just call ./unit.sh
To run talos locally apply the patch from bug 1078619 and follow the steps from comment 2 (You will have to update the URL since we're in a newer version of Firefox).

Comment 3

[Ankit Goyal]

I would like to work on it.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Ankit, i am excited to see your patch.  Do ask questions if you get stuck at all.  I am here to help.  You can also find me on irc.mozilla.org in #ateam, I am jmaher.

Comment 5

[Ankit Goyal]

Attachment: Metro references removed from talos.py

Build and install process is okay after this test.

Comment 6

[Ankit Goyal]

(In reply to Joel Maher (:jmaher) from comment #4)
> Ankit, i am excited to see your patch.  Do ask questions if you get stuck at
> all.  I am here to help.  You can also find me on irc.mozilla.org in #ateam,
> I am jmaher.

I also see a lot of warnings about unused imports and variables. I can also work around that.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8539229 [details] [diff] [review]
Metro references removed from talos.py

Review of attachment 8539229 [details] [diff] [review]:
-----------------------------------------------------------------

one small fixup- lets fix that and try again!

::: mozharness/mozilla/testing/talos.py
@@ -586,5 @@
>          if not self.query_tests():
>              self.fatal("No tests specified; please specify --tests")
>  
>      def install(self):
>          """decorates TestingMixin.install() to handle win metro browser"""

I believe we don't need this entire function "install" anymore :) at the very least the comment and dirs variable should be removed.

Comment 8

[Ankit Goyal]

Attachment: Updated

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8539918 [details] [diff] [review]
Updated

Review of attachment 8539918 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great, I have ran some local tests and it appears to be fine!

Thanks for working on this!

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
https://hg.mozilla.org/build/mozharness/rev/0424b451c005

Ankit, are you interested in more hacking?  Do speak up, there are a lot of things to get involved in and make a difference!

Comment 11

[Ankit Goyal]

(In reply to Joel Maher (:jmaher) from comment #10)
> landed:
> https://hg.mozilla.org/build/mozharness/rev/0424b451c005
> 
> Ankit, are you interested in more hacking?  Do speak up, there are a lot of
> things to get involved in and make a difference!

Yes, i am interested. 
And FYI, while we run ./unit.sh there are lot of unused imports and variables.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

Ankit, thanks for mentioning ./unit.sh issues.  Actually can you run 'tox' as that is setup for unittests in mozharness?

cd mozharness  <- root mozharness directory
hg pull -u
pip install tox
tox

This works for me locally, I get 1 error- lets see if that works for you.

Regarding other projects, we have a lot of them: https://wiki.mozilla.org/Auto-tools/Projects/Everything#Project_Table.  I could use some help on alert manager (a python webserver/database tool and a webui in javascript), but just about any project could benefit from help.  As it is holiday season, please add me (:jmaher) to the cc line of any bugs you want to take up in case the mentors are really on holiday.

Comment 13

[Ankit Goyal]

I am getting errors in building alert manager.
At alert_manager/dockerfiles/alert_manager_db/Dockerfile in:
> RUN apt-get -q -y update && apt-get -q -y upgrade
> RUN apt-get -q -y install mysql-server supervisor

It's weird because they are running fine in terminal by themselves.
I am using Ubuntu 14.04 - x64.

Comment 14

[Ankit Goyal]

This is RESOLVED, right?

Comment 15

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks, I had forgotten the basic cleanup!

Comment 16

[Jordan Lund (:jlund)]

mozharness has been merged to production. patches are live :)