1113165 - Send typing notification pref not present outside of libpurple

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Quentin Headen [:qheaden]]

When compiling Instantbird without purple support, you will get an error everytime you type a character when using a prpl that accesses the purple.conversations.im.send_typing pref.

As mentioned here (http://log.bezut.info/instantbird/141217/#m255) in this IRC conversation, it is a libpurple pref, but non-libpurple prpls use it. This pref needs to be set outside of libpurple to prevent these errors.

An example access of this pref is at: http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#198

Comment 1

[Patrick Cloke [:clokep]]

Note that this affects *ONLY* Instantbird, since Thunderbird defines this at http://dxr.mozilla.org/comm-central/source/mail/app/profile/all-thunderbird.js#855

Likely this should be moved to chat/chat-prefs.js and removed from mail/ and purple/.

Comment 2

[Quentin Headen [:qheaden]]

Attachment: Chat Core Patch 1

Added pref to chat-prefs.js.

Comment 3

[Quentin Headen [:qheaden]]

Attachment: Libpurple Patch 1

Removed pref from libpurple extension.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8538760 [details] [diff] [review]
Chat Core Patch 1

Review of attachment 8538760 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove this from the mail/ prefs.

Comment 5

[Quentin Headen [:qheaden]]

Attachment: Chat Core Patch 2

This updated patch also removes the pref from mail/.

Comment 6

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/f7be78d02446

Comment 7

[aleth [:aleth]]

http://hg.mozilla.org/users/florian_queze.net/purple/rev/5e2b29063be8

Comment 8

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/60b22895feef