1113188 - Add a test to check deletion of multiple contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/15181/

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8540144 [details] [review]
Gaia PR

I ran this on latest nightly Mac B2G desktop and I got failures:
TEST-UNEXPECTED-ERROR | test_delete_all_contacts.py TestDeleteAllContacts.test_delete_all_contacts | ElementNotVisibleException: ElementNotVisibleException: Element is not currently visible and may not be manipulated
in:
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_delete_all_contacts.py", line 28, in test_delete_all_contacts
    contacts_app.tap_confirm_delete()

When I add 2 time.sleep(1) calls, before and after the tap_confirm_delete() call, I can get the test passing.

Also, I think you forgot to put the test file in the manifest.ini file.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8540144 [details] [review]
Gaia PR

I fixed the timing issue on b2gdesktop with waits. I came across another problem: self.assertEqual(len(contacts_app.contacts), 0) didn't sometimes work because the DOM modification was not executed fast enough on b2g desktop. After looking into it, I observed that if there is no element matching a given CSS selector, the test would be 30 seconds longer (marionette timeout). I changed the final assertion there and left a comment.

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8540144 [details] [review]
Gaia PR

Looks wonderful and the test ran without failure on b2g desktop and device 11 times.

Comment 5

[Robert Chira [:RobertC]]

Comment on attachment 8540144 [details] [review]
Gaia PR

A couple of comments left in the PR.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8540144 [details] [review]
Gaia PR

I updated the PR with your comments. I didn't want to duplicate the comment in each function, so I created a protected function and tap_export + tap_delete call it. What do you think?

Comment 7

[Robert Chira [:RobertC]]

Comment on attachment 8540144 [details] [review]
Gaia PR

Merged to master:
https://github.com/mozilla-b2g/gaia/commit/5d859186a935865438c33f4cad8eb7732786d174