1113282 - Crash in MSE conformance test suite due to TrackBuffer initialization racing with shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bobby Holley (:bholley)]

I get a failed MOZ_ASSERT on the AbortVideo tests of [1]. I've got a patch, will push to try.

[1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2015.html?timestamp=1418928742765

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5748e8eecfe9

Comment 2

[Bobby Holley (:bholley)]

Attachment: Check during async TrackBuffer decoder initialization to make sure we haven't been shut down. v1

Comment 3

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4757a1d4a23e

Comment 4

[Carsten Book [:Tomcat]]

sorry backedout and found out this change was innocent for causing https://treeherder.mozilla.org/logviewer.html#?job_id=4797293&repo=mozilla-inbound so relanded in https://hg.mozilla.org/integration/mozilla-inbound/rev/e7dbd3eb21e5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7dbd3eb21e5

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/91e9b39e3c4b

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8538733 [details] [diff] [review]
Check during async TrackBuffer decoder initialization to make sure we haven't been shut down. v1

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. Affects non-MSE code but is well tested by now.
[String/UUID change made/needed]: None.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/521f1e9a8b68