Closed Bug 1113282 Opened 9 years ago Closed 9 years ago

Crash in MSE conformance test suite due to TrackBuffer initialization racing with shutdown

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

I get a failed MOZ_ASSERT on the AbortVideo tests of [1]. I've got a patch, will push to try.

[1] http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2015.html?timestamp=1418928742765
Attachment #8538733 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/e7dbd3eb21e5
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Blocks: 1108707
Comment on attachment 8538733 [details] [diff] [review]
Check during async TrackBuffer decoder initialization to make sure we haven't been shut down. v1

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. Affects non-MSE code but is well tested by now.
[String/UUID change made/needed]: None.
Attachment #8538733 - Flags: approval-mozilla-aurora?
Attachment #8538733 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.