Closed
Bug 1113296
Opened 9 years ago
Closed 9 years ago
Disable match case mode for find-in-page on non-Nightly builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox36 verified, firefox37 verified, fennec36+)
VERIFIED
FIXED
Firefox 37
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
3.56 KB,
patch
|
mfinkle
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Untested. (Checking on something for Margaret first.) I opted to simply make the UI element invisible, trusting that this will cause the least trouble during layout.
Attachment #8538723 -
Flags: review?(mark.finkle)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8538723 [details] [diff] [review] Disable match case mode for find-in-page on non-Nightly builds. v1 >diff --git a/mobile/android/base/FindInPageBar.java b/mobile/android/base/FindInPageBar.java > public void onClick(View v) { > final int viewId = v.getId(); > >- if (viewId == R.id.find_matchcase) { >+ if (MATCH_CASE_ENABLED && viewId == R.id.find_matchcase) { Do we need this? I'd rather minimize the use of the const. > private void sendRequestToFinderHelper(final String request, final String searchString) { > final JSONObject json = new JSONObject(); > try { > json.put("searchString", searchString); >- json.put("matchCase", mMatchCase.isChecked()); >+ json.put("matchCase", MATCH_CASE_ENABLED && mMatchCase.isChecked()); Same here. Can't we just let the default work? Assuming mMatchCase.isChecked() returns false
Attachment #8538723 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > Do we need this? I'd rather minimize the use of the const. I guess we're not setting the click listener, so it'd be OK.
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a208ca082735
Assignee | ||
Comment 5•9 years ago
|
||
Landed with GONE instead of INVISIBLE; the empty space looks bad, but more importantly it makes the text field smaller for no reason.
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8538723 [details] [diff] [review] Disable match case mode for find-in-page on non-Nightly builds. v1 Approval Request Comment [Feature/regressing bug #]: Bug 1050480. [User impact if declined]: UX not as polished as we'd like. [Describe test coverage new/current, TBPL]: N/A [Risks and why]: Approximately zero risk. Patch simply hides the UI element unless you're on Nightly. [String/UUID change made/needed]: None.
Attachment #8538723 -
Flags: approval-mozilla-aurora?
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a208ca082735
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8538723 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-aurora/rev/cd79379ebfa4
Comment 10•9 years ago
|
||
Match case mode for find-in-page is disabled in Firefox for Android 36.0a2 (2015-01-07) Device: Asus Transformer Pad TF300T (Android 4.2.1)
Comment 11•9 years ago
|
||
Verified as fixed on build 37.0a2 (2014-01-14); Device: Asus Transformer Tab (Android 4.0.3).
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•