Created attachment 8538758 [details] [diff] [review] Patch fixing NetBSD/amd64 support. The build on NetBSD/amd64 uses the wrong files. The attached patch lets NetBSD/amd64 be handled like the other BSDs and Linux, and makes mozilla-central as of today compile and work (with a second patch which I'll submit shortly).
The other patch I mentioned is in bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1113379 These two patches are sufficient to get a firefox that displays NetBSD.org and plays movies on youtube.
Comment on attachment 8538758 [details] [diff] [review] Patch fixing NetBSD/amd64 support. See also https://bugzilla.mozilla.org/show_bug.cgi?id=971897 for the recent similar OpenBSD change
Attachment #8538758 - Flags: review?(benjamin) → review+
Pushed, and credited you as author with your @netbsd.org address. https://hg.mozilla.org/integration/mozilla-inbound/rev/324cfbfd323d
Assignee: nobody → wiz
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8538758 [details] [diff] [review] Patch fixing NetBSD/amd64 support. Review of attachment 8538758 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/reflect/xptcall/md/unix/moz.build @@ +19,4 @@ > if '86' in CONFIG['OS_TEST'] and CONFIG['OS_TEST'] != 'x86_64': > DEFINES['MOZ_NEED_LEADING_UNDERSCORE'] = True > > +if CONFIG['OS_ARCH'] in ('GNU'): This looks incorrect. This should be |('GNU',)| to be a tuple rather than a constant string.
but will that actually break, or it's just a stylistic issue ?
I think things would break if you tried compiling for Hurd, or whatever gnu* target triples resolve to nowards.
Might aswell go cleaner and use == then ? -if CONFIG['OS_ARCH'] in ('GNU'): +if CONFIG['OS_ARCH'] == 'GNU': how about this, anyone to rubberstamp it ?
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.