1113374 - xptcall: fix NetBSD/amd64 support

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Thomas Klausner]

Attachment: Patch fixing NetBSD/amd64 support.

The build on NetBSD/amd64 uses the wrong files. The attached patch lets NetBSD/amd64 be handled like the other BSDs and Linux, and makes mozilla-central  as of today compile and work (with a second patch which I'll submit shortly).

Comment 1

[Thomas Klausner]

The other patch I mentioned is in bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1113379
These two patches are sufficient to get a firefox that displays NetBSD.org and plays movies on youtube.

Comment 2

[Landry Breuil (:gaston)]

Comment on attachment 8538758 [details] [diff] [review]
Patch fixing NetBSD/amd64 support.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=971897 for the recent similar OpenBSD change

Comment 3

[Landry Breuil (:gaston)]

Pushed, and credited you as author with your @netbsd.org address.

https://hg.mozilla.org/integration/mozilla-inbound/rev/324cfbfd323d

Comment 4

[:Benjamin Peterson]

Comment on attachment 8538758 [details] [diff] [review]
Patch fixing NetBSD/amd64 support.

Review of attachment 8538758 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/reflect/xptcall/md/unix/moz.build
@@ +19,4 @@
>      if '86' in CONFIG['OS_TEST'] and CONFIG['OS_TEST'] != 'x86_64':
>          DEFINES['MOZ_NEED_LEADING_UNDERSCORE'] = True
>  
> +if CONFIG['OS_ARCH'] in ('GNU'):

This looks incorrect. This should be |('GNU',)| to be a tuple rather than a constant string.

Comment 5

[Landry Breuil (:gaston)]

but will that actually break, or it's just a stylistic issue ?

Comment 6

[Nathan Froyd [:froydnj]]

I think things would break if you tried compiling for Hurd, or whatever gnu* target triples resolve to nowards.

Comment 7

[Landry Breuil (:gaston)]

Might aswell go cleaner and use == then ?

-if CONFIG['OS_ARCH'] in ('GNU'):
+if CONFIG['OS_ARCH'] == 'GNU':

how about this, anyone to rubberstamp it ?

Comment 8

[Nathan Froyd [:froydnj]]

r=me.

Comment 9

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61eaac98828b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/324cfbfd323d
https://hg.mozilla.org/mozilla-central/rev/61eaac98828b