1113463 - GC more dead IPC ParamTraits instances

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

A bunch of the ParamTraits<> specializations in ipc_message_utils.h aren't actually used by any of the code we build and can be deleted.  I'll attach my patch once the latest revision passes Try.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

rs=me on removing any dead code from ipc/chromium!

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1113463-param-traits-gc-hg1.diff

This patch is the union of patches that have passed try separately, so this try run of the combined patch will hopefully pass: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8d8ea0d1e02a

Notes:
* std::{string,map} are used by mozilla::layers::APZTestData (and possibly other things)
* std::wstring is used by ipc/glue/Transport_win.h (and possibly other things, but maybe only on Windows?)

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8538970 [details] [diff] [review]
bug1113463-param-traits-gc-hg1.diff

Reflecting rs=bent from comment #1.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8af69e0a429

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d8af69e0a429