Closed
Bug 1113477
Opened 10 years ago
Closed 10 years ago
GMPParent send node id logged as a failure
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.24 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
In GMPParent we log the sending of node id to a child as a failure: LOGD(("%s::%s: Failed to send node id %p", __CLASS__, __FUNCTION__, (void *)mProcess)); But it's actually not failed when we log this...
Assignee | ||
Comment 1•10 years ago
|
||
Who says I can't do useful work on the last day of the year?
Attachment #8538978 -
Flags: review?(edwin)
Comment on attachment 8538978 [details] [diff] [review] Patch Review of attachment 8538978 [details] [diff] [review]: ----------------------------------------------------------------- Add a LOGE() to the |!ok| blocks with the original messages.
Attachment #8538978 -
Flags: review?(edwin) → review+
Assignee | ||
Comment 3•10 years ago
|
||
There's no LOGE here, so I went with LOGD: https://hg.mozilla.org/integration/mozilla-inbound/rev/446f986dd668
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/446f986dd668
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•