1113565 - [Loop] Wrong or confusing message trying to authenticate (MobileID WITHOUT physical SIM card), with wrong mobile date (e.g. one year before)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Javier de Prado]

Attachment: 2014-11-11-12-44-19.png

STR:
1.- Set mobile Date & Time to current date right.
2.- Open Loop app and make login with valid MobileID 
3.- Logout from Loop.
3.- Change mobile date to one year before. (2013)
4.- Open loop again and try to login with MobileID again.

ACTUAL RESULT:
After entering right credentials, this message is shown (see attachment): "Sorry, due to problems on our side your account session has expired. Please try loggin in again. If the problem persists, you might need to log out from Firefox Accounts o the Setttings App."

EXPECTED RESULT:
IMHO, I think that messages relating to Firefox Accounts should not be displayed trying to login with mobileID. They could confuse to the user.

Comment 1

[Javier de Prado]

Attachment: Error 401, "expired"

WebID screenshot

Comment 2

[Javier de Prado]

Attachment: WebID screenshot

WetID screenshot

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/437

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Not able to reproduce the issue as it is described at comment 0. Javier, could you give a try and collect some logs please? I would be super helpful to enable MobileId debugging.

user_pref("services.mobileid.loglevel", "Debug");
user_pref("services.hawk.loglevel", "Debug");
user_pref("services.hawk.log.sensitive", true);

Comment 5

[Javier de Prado]

I can't reproduce it anymore on FireE.
But following the same STR described above, It is still reproducing on Flame:
Flame build: flame-KK.user.v2.1.188based.B-73.Gecko-8454ca1.Gaia-5c93577
Loop versions: master/51a04dd and 1.1/d1417d1

Comment 6

[Javier de Prado]

Sorry, the correct Flame build version is (not 2.1): flame-KK.user.v2.0.188based.B-143.Gecko-4d85914.Gaia-31d6c94

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

I did my test on Flame running flame-KK.eng.v2.0.AutomationVersion.188based.B-81.Gecko-4d85914.Gaia-31d6c94 and it was working fine. :(

Comment 8

[Javier de Prado]

Attachment: log_20150112.txt

Comment 9

[Javier de Prado]

Attachment: log_20150112_3.txt

Comment 10

[Javier de Prado]

It is always happening without physical SIM card in Flame or FireE devices.

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Logs (MobileID debug enabled)

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Attachment: New alert screen (message changed)

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

Attachment: New alert screen (message changed)

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

Attachment: New alert screen (message changed)

Comment 15

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8547506 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/437

LGTM, thanks a lot José.

Comment 16

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/41e034c29e13e864c0ef6f454693caef00e6ceaf

Javier, should we uplift this to 1.1 branch as well? Please, let me know.

Comment 17

[Javier de Prado]

Yep. This bug should also be solved in version 1.1, and we will take it into account to do regression testing on v1.1
María Angeles, Do you think so?

Comment 18

[Maria Angeles Oteo (:oteo)]

I think it's not worth it as the next planned version 1.1.1 will include this fix.

It's enough verifying that the patch works fine in master branch (next 1.1.1 version)