All users were logged out of Bugzilla on October 13th, 2018

Use add_task in all /browser/devtools/webaudioeditor browser mochitests

RESOLVED FIXED in Firefox 37

Status

RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: pbro, Assigned: pbro)

Tracking

unspecified
Firefox 37
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This is a follow-up to bug 1075319, which advises to use the new, native, add_task() function to define async tests.
This helps reduce a little bit the nb of lines of codes and helps with better error reporting.
Also, most of the devtools codebase uses it now.
(Assignee)

Comment 1

4 years ago
Created attachment 8539212 [details] [diff] [review]
bug1113584-use-add_task-in-audioeditor-tests.patch
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Attachment #8539212 - Flags: review?(jsantell)
(Assignee)

Updated

4 years ago
Blocks: 1105825
Comment on attachment 8539212 [details] [diff] [review]
bug1113584-use-add_task-in-audioeditor-tests.patch

Review of attachment 8539212 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8539212 - Flags: review?(jsantell) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/4eb4d48d4538
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4eb4d48d4538
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.