Closed Bug 1113584 Opened 5 years ago Closed 5 years ago

Use add_task in all /browser/devtools/webaudioeditor browser mochitests

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

This is a follow-up to bug 1075319, which advises to use the new, native, add_task() function to define async tests.
This helps reduce a little bit the nb of lines of codes and helps with better error reporting.
Also, most of the devtools codebase uses it now.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Attachment #8539212 - Flags: review?(jsantell)
Blocks: 1105825
Comment on attachment 8539212 [details] [diff] [review]
bug1113584-use-add_task-in-audioeditor-tests.patch

Review of attachment 8539212 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8539212 - Flags: review?(jsantell) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4eb4d48d4538
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.