Closed
Bug 1113584
Opened 11 years ago
Closed 11 years ago
Use add_task in all /browser/devtools/webaudioeditor browser mochitests
Categories
(DevTools Graveyard :: Web Audio Editor, defect)
DevTools Graveyard
Web Audio Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: pbro, Assigned: pbro)
References
Details
Attachments
(1 file)
|
49.40 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
This is a follow-up to bug 1075319, which advises to use the new, native, add_task() function to define async tests.
This helps reduce a little bit the nb of lines of codes and helps with better error reporting.
Also, most of the devtools codebase uses it now.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Pending try build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7a300e49671f
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8539212 [details] [diff] [review]
bug1113584-use-add_task-in-audioeditor-tests.patch
Review of attachment 8539212 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
Attachment #8539212 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•