Telemetry report: Number of received rooms

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Oscar Patiño González, Assigned: Oscar Patiño González)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

61 bytes, text/x-github-pull-request
Carmen Jimenez Cabezas
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Report number of received rooms including how many of them include subject and were joined in
(Assignee)

Updated

3 years ago
Assignee: nobody → opatinobugzilla
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Blocks: 1099111
(Assignee)

Comment 1

3 years ago
Created attachment 8545935 [details] [review]
proposed patch
Attachment #8545935 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8545935 [details] [review]
proposed patch

I think you have merged two bug (current one and 1113602)
In any case please follow the guide lines of the review in bug 1113602
Attachment #8545935 - Flags: review?(carmen.jimenezcabezas) → review-

Updated

3 years ago
Depends on: 1113602
(Assignee)

Updated

3 years ago
Attachment #8545935 - Attachment is obsolete: true
(Assignee)

Comment 3

3 years ago
Created attachment 8551267 [details] [review]
proposed patch
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas)

Updated

3 years ago
No longer depends on: 1113602
Comment on attachment 8551267 [details] [review]
proposed patch

I left a comment in git, please take a look and rerequest the review. Thanks
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas)
(Assignee)

Updated

3 years ago
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas)

Updated

3 years ago
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas)
(Assignee)

Comment 5

3 years ago
After talking with Product guys, the subject in the received room is no longer needed.
Requesting review.
(Assignee)

Updated

3 years ago
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551267 [details] [review]
proposed patch

LGTM, I only left a nit in git, thanks!
Attachment #8551267 - Flags: review?(carmen.jimenezcabezas) → review+
(Assignee)

Comment 7

3 years ago
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/fe97e19b98b86a30ac354c71c4c491c428a8de35
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.