Closed Bug 1113598 Opened 10 years ago Closed 10 years ago

Telemetry report: Number of received rooms

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: opatinobugzilla, Assigned: opatinobugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

proposed patch
61 bytes, text/x-github-pull-request
macajc
: review+
Details | Review 
Report number of received rooms including how many of them include subject and were joined in
Assignee: nobody → opatinobugzilla
Status: NEW → ASSIGNED
Blocks: 1099111
Attached file proposed patch (obsolete) — 

        Attachment #8545935 -
        Flags: review?(carmen.jimenezcabezas)

    
    

    
  
Comment on attachment 8545935 [details] [review]
proposed patch

I think you have merged two bug (current one and 1113602)
In any case please follow the guide lines of the review in bug 1113602

        Attachment #8545935 -
        Flags: review?(carmen.jimenezcabezas) → review-
Depends on: 1113602

    
  

        Attachment #8545935 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached file
          
        proposed patch
        — 
      

    


  

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas)
No longer depends on: 1113602

    
    

    
  
Comment on attachment 8551267 [details] [review]
proposed patch

I left a comment in git, please take a look and rerequest the review. Thanks

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas)

    
  

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas)

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas)

    
    

    
  
After talking with Product guys, the subject in the received room is no longer needed.
Requesting review.

    
  

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas)

    
    

    
  
Comment on attachment 8551267 [details] [review]
proposed patch

LGTM, I only left a nit in git, thanks!

        Attachment #8551267 -
        Flags: review?(carmen.jimenezcabezas) → review+

    
    

    
  
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/fe97e19b98b86a30ac354c71c4c491c428a8de35
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: