1113639 - Search engines table header in preferences is highlighted

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Petruta Horea [:phorea]]

Reproduced using Nightly 37.0a1 2014-12-18 under Mac OSX 10.9.5, Ubuntu 14.04 64-bit and Win 7 64-bit.

Steps to reproduce:
1. Open Preferences/Search in both in-content and window mode
2. Hover over the table's header
3. Try to click the table's columns

Expected results:
No highlight on table header if there's no action on the columns. 

Actual results:
In-content preferences highlights the header on all platforms; on Ubuntu the columns can be clicked too.
Preferences/Search in separate window allows the columns to be clicked (all platforms) - such as they were buttons. Under Ubuntu and Windows, the text is moved 1px when this happens.

Comment 1

[Florian Quèze [:florian]]

The CSS rule that causes the color of the header to change on hover is: http://hg.mozilla.org/mozilla-central/annotate/3d846527576f/toolkit/themes/shared/in-content/common.inc.css#l644

I think we could add an attribute on the treecol elements to indicate that no sorting is possible, and tweak that CSS selector.

Comment 2

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - Stop highlighting search engines table header

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8554052 [details] [diff] [review]
rev 1 - Stop highlighting search engines table header

Review of attachment 8554052 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/722169be8e14

Comment 5

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/722169be8e14

Comment 6

[[e-mail]]

Its fixed in my browser Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0 , it does highlight