Closed Bug 1113639 Opened 5 years ago Closed 5 years ago

Search engines table header in preferences is highlighted

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38

People

(Reporter: petruta.rasa, Assigned: abdelrahman, Mentored)

References

Details

Attachments

(1 file)

Reproduced using Nightly 37.0a1 2014-12-18 under Mac OSX 10.9.5, Ubuntu 14.04 64-bit and Win 7 64-bit.

Steps to reproduce:
1. Open Preferences/Search in both in-content and window mode
2. Hover over the table's header
3. Try to click the table's columns

Expected results:
No highlight on table header if there's no action on the columns. 

Actual results:
In-content preferences highlights the header on all platforms; on Ubuntu the columns can be clicked too.
Preferences/Search in separate window allows the columns to be clicked (all platforms) - such as they were buttons. Under Ubuntu and Windows, the text is moved 1px when this happens.
The CSS rule that causes the color of the header to change on hover is: http://hg.mozilla.org/mozilla-central/annotate/3d846527576f/toolkit/themes/shared/in-content/common.inc.css#l644

I think we could add an attribute on the treecol elements to indicate that no sorting is possible, and tweak that CSS selector.
Mentor: florian
Comment on attachment 8554052 [details] [diff] [review]
rev 1 - Stop highlighting search engines table header

Review of attachment 8554052 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8554052 - Flags: review?(florian) → review+
Assignee: nobody → a.ahmed1026
https://hg.mozilla.org/mozilla-central/rev/722169be8e14
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
QA Whiteboard: [good first verify]
Its fixed in my browser Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0 , it does highlight
You need to log in before you can comment on or make changes to this bug.