compile error in gfx/layers/ImageContainer.cpp

RESOLVED FIXED in 2.2 S2 (19dec)

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kli, Assigned: kli)

Tracking

unspecified
2.2 S2 (19dec)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8539275 [details] [diff] [review]
gfx-compiled-failed.patch

Robert, now L is on bring up stage so camera is not enabled. Finally camera will be enabled, but this compile error will block at the moment. Could you review this patch? Thanks!
Attachment #8539275 - Flags: review?(roc)

Updated

3 years ago
Blocks: 1094121

Updated

3 years ago
Depends on: 938034

Comment 2

3 years ago
Comment on attachment 8539275 [details] [diff] [review]
gfx-compiled-failed.patch

Since this is the last patch blocking gonk-L build and it looks pretty simple/uncontroversial, requesting review from sotaro in case he can get to it sooner.
Attachment #8539275 - Flags: review?(sotaro.ikeda.g)
Attachment #8539275 - Flags: review?(roc) → review+

Updated

3 years ago
Attachment #8539275 - Flags: review?(sotaro.ikeda.g) → review+

Comment 3

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/eae05265f039
Assignee: nobody → kli
https://hg.mozilla.org/mozilla-central/rev/eae05265f039
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
(Assignee)

Comment 5

3 years ago
There is bustage when camera is enabled and webrtc is not enabled. Re-open to update the patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

3 years ago
Created attachment 8541101 [details] [diff] [review]
bug-1113655-2.patch

Alfredo, As 'GonkCameraImage.h' is included from webtrc, so I think we should also use MOZ_WEBTRC for condition check. How do you thinks?

Sotaro, To fix the error in comment 5, we need to update the patch. Could you review this patch?

Thanks!
Attachment #8541101 - Flags: review?(sotaro.ikeda.g)
Attachment #8541101 - Flags: feedback?(ayang)
Attachment #8541101 - Flags: feedback?(ayang) → feedback+

Updated

3 years ago
Blocks: 1107300

Updated

3 years ago
Attachment #8541101 - Flags: review?(sotaro.ikeda.g) → review+
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/8ddc750a2924
https://hg.mozilla.org/mozilla-central/rev/8ddc750a2924
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.