compile error in gfx/layers/ImageContainer.cpp

RESOLVED FIXED in 2.2 S2 (19dec)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: seinlin, Assigned: seinlin)

Tracking

unspecified
2.2 S2 (19dec)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

No description provided.
Robert, now L is on bring up stage so camera is not enabled. Finally camera will be enabled, but this compile error will block at the moment. Could you review this patch? Thanks!
Attachment #8539275 - Flags: review?(roc)
Blocks: gonk-L
Depends on: 938034
Comment on attachment 8539275 [details] [diff] [review]
gfx-compiled-failed.patch

Since this is the last patch blocking gonk-L build and it looks pretty simple/uncontroversial, requesting review from sotaro in case he can get to it sooner.
Attachment #8539275 - Flags: review?(sotaro.ikeda.g)
Attachment #8539275 - Flags: review?(sotaro.ikeda.g) → review+
https://hg.mozilla.org/mozilla-central/rev/eae05265f039
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
There is bustage when camera is enabled and webrtc is not enabled. Re-open to update the patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Alfredo, As 'GonkCameraImage.h' is included from webtrc, so I think we should also use MOZ_WEBTRC for condition check. How do you thinks?

Sotaro, To fix the error in comment 5, we need to update the patch. Could you review this patch?

Thanks!
Attachment #8541101 - Flags: review?(sotaro.ikeda.g)
Attachment #8541101 - Flags: feedback?(ayang)
Attachment #8541101 - Flags: feedback?(ayang) → feedback+
Attachment #8541101 - Flags: review?(sotaro.ikeda.g) → review+
https://hg.mozilla.org/mozilla-central/rev/8ddc750a2924
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.