1113655 - compile error in gfx/layers/ImageContainer.cpp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: gfx-compiled-failed.patch

Robert, now L is on bring up stage so camera is not enabled. Finally camera will be enabled, but this compile error will block at the moment. Could you review this patch? Thanks!

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8539275 [details] [diff] [review]
gfx-compiled-failed.patch

Since this is the last patch blocking gonk-L build and it looks pretty simple/uncontroversial, requesting review from sotaro in case he can get to it sooner.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eae05265f039

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eae05265f039

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

There is bustage when camera is enabled and webrtc is not enabled. Re-open to update the patch.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: bug-1113655-2.patch

Alfredo, As 'GonkCameraImage.h' is included from webtrc, so I think we should also use MOZ_WEBTRC for condition check. How do you thinks?

Sotaro, To fix the error in comment 5, we need to update the patch. Could you review this patch?

Thanks!

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8ddc750a2924

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8ddc750a2924