1113662 - [v2.2] Investigate test_sms_with_attachments tap_capture failure

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

Attachment: logcat.txt

test_sms_with_attachments started failing on Jenkins when trying to tap on the select button. From the screenshots it's visible that the picture was not taken which would suggest some issues with tap_capture().

The issue cannot be reproduce manually.
With automation the reproduction rate is: 4 out of 10

This might require some refactoring in the camera app.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

Adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/591/console
The failures in the adhoc are because of Bug 1109213

Comment 2

[Florin Strugariu [:Bebe]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

Let's move those lines in wait_for_capture_ready()

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

Looks good. I agree with Bebe's point. Also there's a change about a selector that doesn't look related to the other parts of the fix, does it?

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

Locator updated; I also added a comment in the PR regarding the addition of the new waits in wait_for_capture_ready()

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

Clearing the review until bug 1122119 gets fixed.

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

I updated the PR and also started a new adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/619/HTML_Report/. There are 5 unrelated failures. 
I also left a comment in the bug.
Can you guys take a look again? Thanks!

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115

LGTM.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Merge in master at: https://github.com/mozilla-b2g/gaia/commit/06b165123950df104de85caab9678414cc41d064