Closed
Bug 1113662
Opened 10 years ago
Closed 10 years ago
[v2.2] Investigate test_sms_with_attachments tap_capture failure
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: RobertC, Assigned: viorela)
References
Details
Attachments
(2 files)
test_sms_with_attachments started failing on Jenkins when trying to tap on the select button. From the screenshots it's visible that the picture was not taken which would suggest some issues with tap_capture().
The issue cannot be reproduce manually.
With automation the reproduction rate is: 4 out of 10
This might require some refactoring in the camera app.
Reporter | ||
Updated•10 years ago
|
QA Whiteboard: [fxosqa-auto-backlog+]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → viorela.ioia
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-backlog+][fxosqa-auto-s7]
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: [fxosqa-auto-backlog+][fxosqa-auto-s7] → [fxosqa-auto-from-s7][fxosqa-auto-s8]
Assignee | ||
Comment 1•10 years ago
|
||
Adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/591/console
The failures in the adhoc are because of Bug 1109213
Attachment #8549717 -
Flags: review?(jlorenzo)
Attachment #8549717 -
Flags: review?(florin.strugariu)
Comment 2•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
Let's move those lines in wait_for_capture_ready()
Attachment #8549717 -
Flags: review?(florin.strugariu) → review-
Comment 3•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
Looks good. I agree with Bebe's point. Also there's a change about a selector that doesn't look related to the other parts of the fix, does it?
Attachment #8549717 -
Flags: review?(jlorenzo) → review-
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
Locator updated; I also added a comment in the PR regarding the addition of the new waits in wait_for_capture_ready()
Attachment #8549717 -
Flags: review?(jlorenzo)
Attachment #8549717 -
Flags: review?(florin.strugariu)
Attachment #8549717 -
Flags: review-
Updated•10 years ago
|
Attachment #8549717 -
Flags: review?(florin.strugariu) → review-
Comment 5•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
Clearing the review until bug 1122119 gets fixed.
Attachment #8549717 -
Flags: review?(jlorenzo)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
I updated the PR and also started a new adhoc run: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/619/HTML_Report/. There are 5 unrelated failures.
I also left a comment in the bug.
Can you guys take a look again? Thanks!
Attachment #8549717 -
Flags: review?(jlorenzo)
Attachment #8549717 -
Flags: review?(florin.strugariu)
Attachment #8549717 -
Flags: review-
Updated•10 years ago
|
Attachment #8549717 -
Flags: review?(florin.strugariu) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8549717 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/27115
LGTM.
Attachment #8549717 -
Flags: review?(jlorenzo) → review+
Comment 8•10 years ago
|
||
Merge in master at: https://github.com/mozilla-b2g/gaia/commit/06b165123950df104de85caab9678414cc41d064
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•