1113673 - Loop icon is not blue during a call between FxA Accounts

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect, P5)

Description

[Ada [:adalucinet]]

Reproducible on: Firefox 35 beta 5 (Build ID: 20141218174327), Aurora 36.0a2 (Build ID: 20141219004003) and Nightly 37.0a1 (Build ID: 20141219030202)
Platforms: Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 32-bit.

Steps to reproduce:
1. Click on Loop button and Sign In.
2. Perform a call between FxA Accounts.

Expected results: Loop icon is blue during the call (on the caller side).

Actual results: Loop icon is not blue.

Notes:
1. Also reproducible with Firefox 34 beta 11.

Comment 1

[Mike de Boer [:mikedeboer]]

I'd like to first establish that we expect the Loop button icon to turn blue when a direct call is in progress.

Comment 2

[Maire Reavy [:mreavy]]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> I'd like to first establish that we expect the Loop button icon to turn blue
> when a direct call is in progress.

Hey Sevaan -- I don't believe this was discussed in the original spec (which would have been pre-rooms spec).  Do you want the icon to turn blue?   If so, can we treat this as a "normal" bug and fix it in either Fx37 or fx38 and let it ride the trains?  Or do you want it in sooner (e.g. Fx36)?  I don't feel we need this for Fx35.  Thoughts?

Comment 3

[Maire Reavy [:mreavy]]

Marking this as Fx36? for now to keep it on our radar until we have a larger discussion.  I don't believe there is a privacy or awareness issue, but I want to verify that others agree.

Comment 4

[Sevaan Franks [:sevaan]]

My understanding was that the icon turns blue:

- When a conversation is open
- When you are in an active call
- When you are not in a conversation but someone joins your room.

Basically the icon should be blue is Hello is active in anyway.

Does this sound right?

Comment 5

[Maire Reavy [:mreavy]]

(In reply to Sevaan Franks [:sevaan] from comment #4)
> My understanding was that the icon turns blue:
> 
> - When a conversation is open
> - When you are in an active call
> - When you are not in a conversation but someone joins your room.
> 
> Basically the icon should be blue is Hello is active in anyway.
> 
> Does this sound right?

I don't believe we've ever spelled out when the icon should be blue outside of Rooms, but the behavior you spell out makes sense.

Should we target this bug for Fx37 (fix it and let it ride the trains)?  Or do we need/want it in Fx36?

Comment 6

[Sevaan Franks [:sevaan]]

I think the icon colour is rather important piece of Hello signalling to the user to pay attention. Without some consistent rules users may miss people joining their rooms (although we are working on other methods to alert users as well). I think this one should be sooner rather than later.

Comment 7

[Sevaan Franks [:sevaan]]

Sorry, my comment was referring to having consistent rules for icon signalling in general.

If we can fix this particular bug in 36, that would be great, but it's probably not high priority.

Comment 8

[Maire Reavy [:mreavy]]

Thanks, Sevaan.  I'm marking this as a "normal" bug targeted for Fx36.

Comment 9

[:shell escalante]

asking if you want to push back on delaying.. based on priorities this is lower in my thoughts

Comment 10

[Sevaan Franks [:sevaan]]

Sure, this is lower than others. Maybe someone in the community can pick it up to usher things along.

Comment 11

[Paul Silaghi, QA [:pauly]]

Something in here https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a82581055c06&tochange=1a16300913e7 made the icon no longer be blue on login.

Comment 12

[u279076]

(In reply to Paul Silaghi, QA [:pauly] from comment #11)
> Something in here
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=a82581055c06&tochange=1a16300913e7 made the icon no
> longer be blue on login.

Maybe bug 1102432 or bug 1100595?

Comment 13

[Mark Banner (:standard8)]

We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing direct call related bugs as wontfix.

Tracking id: directcallclosing