Closed Bug 1113683 Opened 5 years ago Closed 5 years ago

Add nsNullChannel

Categories

(Core :: Networking, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: valentin, Assigned: valentin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We need a null channel implementation for several bugs.
It should implement:
nsIHttpChannel
nsITimedChannel
nsINullChannel (so that it can be distinguished between real nsHttpChannel and the fake one.)
Attached patch Add dummy NullHttpChannel (obsolete) — Splinter Review
Attachment #8541881 - Flags: review?(mcmanus)
Dragana, can you take a look at the patch and tell me if there's any missing functionality you need for bug 862856?
Flags: needinfo?(dd.mozilla)
It is fine, there is everything needed for bug 862856.
Flags: needinfo?(dd.mozilla)
Made destructor be virtual, and constructor now copies initiatorType
Attachment #8542112 - Flags: review?(mcmanus)
Attachment #8541881 - Attachment is obsolete: true
Attachment #8541881 - Flags: review?(mcmanus)
Comment on attachment 8542112 [details] [diff] [review]
Add dummy NullHttpChannel

Review of attachment 8542112 [details] [diff] [review]:
-----------------------------------------------------------------

couple nits to think about below.. but lgtm to proceed either way

::: netwerk/base/public/nsINullChannel.idl
@@ +9,5 @@
> + * an object isn't a complete implementation of its interfaces.
> + * For example, a consumer can QI NullHttpChannel to nsINullChannel,
> + * to determine if the object is just a dummy implementation of nsIHttpChannel.
> + */
> +[scriptable, uuid(4610b901-df41-4bb4-bd3f-fd4d6b6d8d68)]

scriptable, builtinclass, uuid..

::: netwerk/protocol/http/NullHttpChannel.h
@@ +14,5 @@
> +
> +namespace mozilla {
> +namespace net {
> +
> +class NullHttpChannel

can we do class NullHttpChannel MOZ_FINAL and drop the virtuals?
Attachment #8542112 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/dfea3cd26c29
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.