1113683 - Add nsNullChannel

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

We need a null channel implementation for several bugs.
It should implement:
nsIHttpChannel
nsITimedChannel
nsINullChannel (so that it can be distinguished between real nsHttpChannel and the fake one.)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Add dummy NullHttpChannel

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Dragana, can you take a look at the patch and tell me if there's any missing functionality you need for bug 862856?

Comment 3

[Dragana Damjanovic [:dragana]]

It is fine, there is everything needed for bug 862856.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Add dummy NullHttpChannel

Made destructor be virtual, and constructor now copies initiatorType

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8542112 [details] [diff] [review]
Add dummy NullHttpChannel

Review of attachment 8542112 [details] [diff] [review]:
-----------------------------------------------------------------

couple nits to think about below.. but lgtm to proceed either way

::: netwerk/base/public/nsINullChannel.idl
@@ +9,5 @@
> + * an object isn't a complete implementation of its interfaces.
> + * For example, a consumer can QI NullHttpChannel to nsINullChannel,
> + * to determine if the object is just a dummy implementation of nsIHttpChannel.
> + */
> +[scriptable, uuid(4610b901-df41-4bb4-bd3f-fd4d6b6d8d68)]

scriptable, builtinclass, uuid..

::: netwerk/protocol/http/NullHttpChannel.h
@@ +14,5 @@
> +
> +namespace mozilla {
> +namespace net {
> +
> +class NullHttpChannel

can we do class NullHttpChannel MOZ_FINAL and drop the virtuals?

Comment 6

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dfea3cd26c29

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dfea3cd26c29