1113684 - display of <img> alt-text should respect writing modes

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase for broken-image icon and alt-text display

See testcase. When the broken-image icon is *not* shown, the alt text respects the writing-mode as expected; but when we're displaying the broken-image icon, the alt text no longer renders correctly for vertical modes.

(Also, in the vertical-rl case, we should move the broken-image icon to the top right of the image frame, as we do for bidi-rtl.)

Comment 1

[Jonathan Kew [:jfkthame]]

Display of the alt text alongside a broken-image icon depends on nsLayoutUtils::DrawString, so the first patch in bug 1111944 is the foundation for this. With that in place, we can then fix up the formatting/positioning of the string in nsImageFrame::DisplayAltText.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Handle vertical writing modes when displaying alt-text alongside a broken-image icon

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 8539306 [details] [diff] [review]
Handle vertical writing modes when displaying alt-text alongside a broken-image icon

Review of attachment 8539306 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: part 2 - Update test from bug 1105268 to account for position of broken-image icon now being sensitive to vertical-rl mode

This is needed because the patch (intentionally) moves the broken-image icon to the top-right of the frame in vertical-rl mode, so the reference for this testcase needs to be updated accordingly.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fc59f36a868
https://hg.mozilla.org/integration/mozilla-inbound/rev/5179ff7d7573

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1fc59f36a868
https://hg.mozilla.org/mozilla-central/rev/5179ff7d7573