Closed Bug 1113739 Opened 6 years ago Closed 6 years ago

Make sure loop.gettingStarted.resumeOnFirstJoin is set before resuming the Hello tour

Categories

(Firefox :: Tours, defect)

defect
Not set
major
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

I was moving the check of loop.gettingStarted.resumeOnFirstJoin during development of bug 1080953 and forgot to paste it.

The tour is currently resuming every time the owner and a guest are in a room regardless of loop.gettingStarted.resumeOnFirstJoin.
Flags: qe-verify-
Flags: firefox-backlog+
This should fix the multiple the tabs that agibson was seeing in bug 1113574 comment 1 I think.
Attached file MozReview Request: bz://1113739/MattN (obsolete) —
Attachment #8539396 - Flags: review?(dolske)
/r/1605 - Bug 1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is true before resuming the Hello tour. r=dolske

Pull down this commit:

hg pull review -r 662e249b656072fb944a3b5d08a1dcbca1312415
Attachment #8539396 - Flags: review?(dolske) → review+
Comment on attachment 8539396 [details]
MozReview Request: bz://1113739/MattN

[Triage Comment]

Needed for Fx35 Hello tour.
Attachment #8539396 - Flags: approval-mozilla-beta+
Attachment #8539396 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/0cdeb44ae3d1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Attachment #8539396 - Attachment is obsolete: true
Attachment #8618940 - Flags: review+
You need to log in before you can comment on or make changes to this bug.