Make sure loop.gettingStarted.resumeOnFirstJoin is set before resuming the Hello tour

RESOLVED FIXED in Firefox 35

Status

()

defect
--
major
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 37
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I was moving the check of loop.gettingStarted.resumeOnFirstJoin during development of bug 1080953 and forgot to paste it.

The tour is currently resuming every time the owner and a guest are in a room regardless of loop.gettingStarted.resumeOnFirstJoin.
Flags: qe-verify-
Flags: firefox-backlog+
This should fix the multiple the tabs that agibson was seeing in bug 1113574 comment 1 I think.
/r/1605 - Bug 1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is true before resuming the Hello tour. r=dolske

Pull down this commit:

hg pull review -r 662e249b656072fb944a3b5d08a1dcbca1312415
Attachment #8539396 - Flags: review?(dolske) → review+
Comment on attachment 8539396 [details]
MozReview Request: bz://1113739/MattN

[Triage Comment]

Needed for Fx35 Hello tour.
Attachment #8539396 - Flags: approval-mozilla-beta+
Attachment #8539396 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/0cdeb44ae3d1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Attachment #8539396 - Attachment is obsolete: true
Attachment #8618940 - Flags: review+
You need to log in before you can comment on or make changes to this bug.