1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is set before resuming the Hello tour

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Matthew N. [:MattN]]

I was moving the check of loop.gettingStarted.resumeOnFirstJoin during development of bug 1080953 and forgot to paste it.

The tour is currently resuming every time the owner and a guest are in a room regardless of loop.gettingStarted.resumeOnFirstJoin.

Comment 1

[Matthew N. [:MattN]]

This should fix the multiple the tabs that agibson was seeing in bug 1113574 comment 1 I think.

Comment 2

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1113739/MattN

Comment 3

[Matthew N. [:MattN]]

/r/1605 - Bug 1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is true before resuming the Hello tour. r=dolske

Pull down this commit:

hg pull review -r 662e249b656072fb944a3b5d08a1dcbca1312415

Comment 4

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/1603/#review1009

Ship It!

Comment 5

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/0cdeb44ae3d1

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 8539396 [details]
MozReview Request: bz://1113739/MattN

[Triage Comment]

Needed for Fx35 Hello tour.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/064cdb43232b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0cdeb44ae3d1

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4576aea510d0

Comment 11

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is true before resuming the Hello tour. r=dolske