Closed
Bug 1113739
Opened 9 years ago
Closed 9 years ago
Make sure loop.gettingStarted.resumeOnFirstJoin is set before resuming the Hello tour
Categories
(Firefox :: Tours, defect)
Firefox
Tours
Tracking
()
People
(Reporter: MattN, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
I was moving the check of loop.gettingStarted.resumeOnFirstJoin during development of bug 1080953 and forgot to paste it. The tour is currently resuming every time the owner and a guest are in a room regardless of loop.gettingStarted.resumeOnFirstJoin.
Flags: qe-verify-
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
This should fix the multiple the tabs that agibson was seeing in bug 1113574 comment 1 I think.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8539396 -
Flags: review?(dolske)
Assignee | ||
Comment 3•9 years ago
|
||
/r/1605 - Bug 1113739 - Make sure loop.gettingStarted.resumeOnFirstJoin is true before resuming the Hello tour. r=dolske Pull down this commit: hg pull review -r 662e249b656072fb944a3b5d08a1dcbca1312415
Updated•9 years ago
|
Attachment #8539396 -
Flags: review?(dolske) → review+
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/1603/#review1009 Ship It!
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0cdeb44ae3d1
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•9 years ago
|
Comment 6•9 years ago
|
||
Comment on attachment 8539396 [details]
MozReview Request: bz://1113739/MattN
[Triage Comment]
Needed for Fx35 Hello tour.
Attachment #8539396 -
Flags: approval-mozilla-beta+
Attachment #8539396 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0cdeb44ae3d1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/4576aea510d0
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8539396 -
Attachment is obsolete: true
Attachment #8618940 -
Flags: review+
Assignee | ||
Comment 11•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•