Closed
Bug 1113780
Opened 6 years ago
Closed 6 years ago
Update error page for sslv3 to rely on a more specific error than no_cypher_overlap
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: Gijs, Assigned: emk)
References
Details
Attachments
(1 file)
2.00 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1098371 +++
Updated•6 years ago
|
Flags: firefox-backlog+
Assignee | ||
Comment 2•6 years ago
|
||
Apply this on top of the patch from bug 1098371. The sslv3 error page will not be displayed on m-c without this patch.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8546624 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 3•6 years ago
|
||
Comment on attachment 8546624 [details] [diff] [review] Use SSL_ERROR_UNSUPPORTED_VERSION for SSLv3 error page Review of attachment 8546624 [details] [diff] [review]: ----------------------------------------------------------------- rs=me - thanks for the patch! Note there might be slight bitrot because of the removal of the trailing whitespace as per the review nits. I already landed bug 1098371 on fx-team, so landing this on there is probably easiest. I can do that if you don't have an fx-team tree to hand.
Attachment #8546624 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 4•6 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3) > Note there might be slight bitrot because of the removal of the trailing > whitespace as per the review nits. I already landed bug 1098371 on fx-team, > so landing this on there is probably easiest. I can do that if you don't > have an fx-team tree to hand. OK, please. (I'm usually working on mozilla-inbound, so I have no fx-team tree to hand.)
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Reporter | ||
Comment 5•6 years ago
|
||
remote: https://hg.mozilla.org/integration/fx-team/rev/d5977152c82a
Flags: qe-verify+
Flags: in-testsuite-
Comment 6•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d5977152c82a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•6 years ago
|
Iteration: --- → 37.3 - 12 Jan
Comment 7•6 years ago
|
||
Verified fixed on Nightly 38.0a1 (2015-01-22) and Aurora 37.0a2 (2015-01-22), using Ubuntu 12.04 32 bit, Windows 7 64 bit and Mac OS X 10.9.5 with https://sslv3.dshield.org/ as a test page. The updated neterror page now states 'ssl_error_unsupported_version'.
Reporter | ||
Comment 8•6 years ago
|
||
Uplifted to beta per the approvals in bug 1098371: https://hg.mozilla.org/releases/mozilla-beta/rev/ea3b10634381
status-firefox36:
--- → fixed
Comment 9•6 years ago
|
||
Verified fixed on Firefox 36 RC build 2 (BuildID=20150222232811), using Ubuntu 14.04 64 bit, Windows 7 64 bit and Mac OS X 10.10 with: https://contact.russlavbank.com/ and https://sslv3.dshield.org/ ("security.tls.version.fallback-limit" set to 3 as mentioned in bug 1098371). The updated neterror page displays with error 'ssl_error_unsupported_version' as expected.
You need to log in
before you can comment on or make changes to this bug.
Description
•