1113844 - Error clicking on download notification

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I'm seeing this when clicking on a download notification:

I/Gecko   (14114): *************************
I/Gecko   (14114): A coding exception was thrown in a Promise resolution callback.
I/Gecko   (14114): See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
I/Gecko   (14114): 
I/Gecko   (14114): Full message: ReferenceError: id is not defined
I/Gecko   (14114): Full stack: DownloadNotifications.onClick/<@resource://gre/modules/DownloadNotifications.jsm:157:11
I/Gecko   (14114): Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
I/Gecko   (14114): this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
I/Gecko   (14114): this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
I/Gecko   (14114): 
I/Gecko   (14114): *************************
W/GeckoConsole(14114): [JavaScript Error: "id is not defined" {file: "resource://gre/modules/DownloadNotifications.jsm" line: 157}]

Comment 1

[:Margaret Leibovic]

I'm having trouble reproducing this locally. It looks like this would only happen if you have a succeeded download that fails to launch with file.launch():
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/DownloadNotifications.jsm#157

wesj, what kind of file were you trying to open?

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1113844/margaret

Comment 3

[:Margaret Leibovic]

/r/1645 - Bug 1113844 - Fix parameters in showInAboutDownloads call

Pull down this commit:

hg pull review -r 5ba433ad66766a3932f275ef3ac2d5e5b8092e6d

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/1643/#review1045

Ship It!

Comment 5

[:Margaret Leibovic]

I verified that this fix works locally by commenting out the file.launch() bit to force the showInAboutDownloads call.

https://hg.mozilla.org/integration/fx-team/rev/86225c7d5bd0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86225c7d5bd0

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

does this need uplift anywhere?

Comment 8

[:Margaret Leibovic]

(In reply to Kevin Brosnan [:kbrosnan] from comment #7)
> does this need uplift anywhere?

No, this was a regression from bug 901360.

Comment 10

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1113844 - Fix parameters in showInAboutDownloads call