Error clicking on download notification

RESOLVED FIXED in Firefox 37

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: wesj, Assigned: Margaret)

Tracking

unspecified
Firefox 37
ARM
Android
Points:
---

Firefox Tracking Flags

(fennec37+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
I'm seeing this when clicking on a download notification:

I/Gecko   (14114): *************************
I/Gecko   (14114): A coding exception was thrown in a Promise resolution callback.
I/Gecko   (14114): See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
I/Gecko   (14114): 
I/Gecko   (14114): Full message: ReferenceError: id is not defined
I/Gecko   (14114): Full stack: DownloadNotifications.onClick/<@resource://gre/modules/DownloadNotifications.jsm:157:11
I/Gecko   (14114): Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
I/Gecko   (14114): this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
I/Gecko   (14114): this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
I/Gecko   (14114): 
I/Gecko   (14114): *************************
W/GeckoConsole(14114): [JavaScript Error: "id is not defined" {file: "resource://gre/modules/DownloadNotifications.jsm" line: 157}]

Updated

3 years ago
tracking-fennec: --- → ?
Blocks: 901360
OS: Mac OS X → Android
Hardware: x86 → ARM
(Assignee)

Comment 1

3 years ago
I'm having trouble reproducing this locally. It looks like this would only happen if you have a succeeded download that fails to launch with file.launch():
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/DownloadNotifications.jsm#157

wesj, what kind of file were you trying to open?
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 2

3 years ago
Created attachment 8540304 [details]
MozReview Request: bz://1113844/margaret
Attachment #8540304 - Flags: review?(mark.finkle)
(Assignee)

Comment 3

3 years ago
/r/1645 - Bug 1113844 - Fix parameters in showInAboutDownloads call

Pull down this commit:

hg pull review -r 5ba433ad66766a3932f275ef3ac2d5e5b8092e6d
Attachment #8540304 - Flags: review?(mark.finkle) → review+
https://reviewboard.mozilla.org/r/1643/#review1045

Ship It!
(Assignee)

Comment 5

3 years ago
I verified that this fix works locally by commenting out the file.launch() bit to force the showInAboutDownloads call.

https://hg.mozilla.org/integration/fx-team/rev/86225c7d5bd0
https://hg.mozilla.org/mozilla-central/rev/86225c7d5bd0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
does this need uplift anywhere?
Flags: needinfo?(wjohnston)
tracking-fennec: ? → +
(Assignee)

Comment 8

3 years ago
(In reply to Kevin Brosnan [:kbrosnan] from comment #7)
> does this need uplift anywhere?

No, this was a regression from bug 901360.
tracking-fennec: + → 37+
Flags: needinfo?(wjohnston)
(Assignee)

Comment 9

3 years ago
Comment on attachment 8540304 [details]
MozReview Request: bz://1113844/margaret
Attachment #8540304 - Attachment is obsolete: true
Attachment #8618941 - Flags: review+
(Assignee)

Comment 10

3 years ago
Created attachment 8618941 [details]
MozReview Request: Bug 1113844 - Fix parameters in showInAboutDownloads call
You need to log in before you can comment on or make changes to this bug.