1114398 - SVG can mix up Paths with wrong DrawTarget types

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Bas Schouten (:bas.schouten)]

SVG can use cached paths that were created for a different DT backend than is currently being requested.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Make Direct2D paths specifically typed to a backend type

This patch will allow us to match D2D paths through dt->GetBackendType() == path->GetBackendType().

In theory we don't need this restriction, but not having it will only hide bugs with D2D/D2D1.1 mismatches. Realistically a path should just always be used with the backend type it's created for.

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Test whether the path backend matches the DrawTarget backend

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8539881 [details] [diff] [review]
Part 1: Make Direct2D paths specifically typed to a backend type

Review of attachment 8539881 [details] [diff] [review]:
-----------------------------------------------------------------

Does this interact with the Canvas path stuff when the path was created for a different backend then it is being used on?

Comment 4

[Bas Schouten (:bas.schouten)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8539881 [details] [diff] [review]
> Part 1: Make Direct2D paths specifically typed to a backend type
> 
> Review of attachment 8539881 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this interact with the Canvas path stuff when the path was created for
> a different backend then it is being used on?

In theory it shouldn't because this sort of mix-up simply shouldn't occur.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8309d6ce7a38
https://hg.mozilla.org/mozilla-central/rev/d5ead6673b95