Closed
Bug 1114411
Opened 11 years ago
Closed 11 years ago
Do not call replyToMarkdownComment() if user pref use_markdown = off
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: perf, regression)
Attachments
(1 file)
|
1.12 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
I don't have Markdown enabled (my user pref use_markdown is off), and so all comments are displayed as plain text. So there is no need to call replyToMarkdownComment() to get the original/plain text comments. We already have them. We should call replyToComment() directly, avoiding a slow and useless JSONRPC call to Bug.comments.
|
Assignee | |
Comment 1•11 years ago
|
||
This patch is based on bug 1093924, so that one must be checked in first.
I define markdown_enabled out of the FOREACH loop, because its value won't change across comments and it can become pretty slow if there are tens or hundreds of comments.
Attachment #8539899 -
Flags: review?(glob)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8539899 [details] [diff] [review]
bug0-12.diff
Review of attachment 8539899 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8539899 -
Flags: review?(glob) → review+
|
|
||
Updated•11 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 3•11 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
b290e22..1447622 master -> master
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•