1114445 - Update sync migration to new UX flows

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

There are some relatively minor tweaks to the migration strings - http://is.gd/sync_migration_ux_pdf.  While going through this I also found a few other things we weren't doing quite right (particularly around the "join the party" flows).

This bug is to update what's already landed to these new requirements.

Comment 1

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: 0004-Bug-1114445-update-sync-migration-flows-to-reflect-l.patch

Drew should be back long enough before the merge to review this - although this must land before that merge as it has strings.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8539925 [details] [diff] [review]
0004-Bug-1114445-update-sync-migration-flows-to-reflect-l.patch

Review of attachment 8539925 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/sync.js
@@ +303,5 @@
>        case fxaMigrator.STATE_USER_FXA: {
>          let sb = this._accountsStringBundle;
> +        // There are 2 cases here - no email address means it is an offer on
> +        // the first device (so the user is prompted to create an account).
> +        // If there is an email address it is the "join the party" flow, so the

This comment is a better explanation than the similar comment you added in browser-fxaccounts.js IMO.

::: browser/locales/en-US/chrome/browser/accounts.properties
@@ +11,5 @@
>  upgradeToFxA.accessKey = U
>  
> +# LOCALIZATION NOTE (upgradeToFxASubsequent.description)
> +# %S = Email address of user's Firefox Account
> +upgradeToFxASubsequent.description = Sync was upgraded on another device by %S. Resume syncing?

Hmm, "upgradeToFxASubsequent" makes me think that these strings are still about asking the user to upgrade.  It's more like "upgraded on another device" or "sign in on this device."

Comment 3

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

(In reply to Drew Willcoxon :adw from comment #2)

> Hmm, "upgradeToFxASubsequent" makes me think that these strings are still
> about asking the user to upgrade.

But they are :)  It's saying "sync was upgraded elsewhere, do you want to upgrade here too?"

> It's more like "upgraded on another
> device" or "sign in on this device."

I agree the name sucks - do you have a concrete suggestion?  I spent quite a few brain-cycles trying to come up with a good name, and even with a week of reflection I'm still stuck :)

Comment 4

[Drew Willcoxon :adw]

To my mind there's only one upgrade, not an upgrade per device.  Once you do the upgrade, from one device, you only have to sign in on other devices.

signInAfterUpgradeOnOtherDevice?  It's not a huge deal, r+ with upgradeToFxASubsequent too.

Comment 5

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa7815576ee

https://hg.mozilla.org/integration/fx-team/rev/7a472c24f6aa

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a472c24f6aa