Need a port of the new print dialog to BeOS

VERIFIED FIXED in mozilla0.9.7

Status

()

Core
Printing: Output
P1
blocker
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

({helpwanted})

Trunk
mozilla0.9.7
All
BeOS
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

17 years ago
bug 84947 ("We need a "better" print dialog...") introduced a new print dialog
for Unix+OS/2.
Unfortunately it seems that I missed that BeOS uses the PostScript module for
printing, too - therefore we have to port the changes "done" to the Xlib/GTK+
widget code to BeOS, too...

Looking at attachment 58681 [details] [diff] [review] and grep'ping out the Xlib toolkit changes:
The following files have been changed - we only have to port the changes to the
matching BeOS files:
-- snip --
mozilla/gfx/src/xlib/Makefile.in
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.cpp
mozilla/gfx/src/xlib/nsDeviceContextSpecXlib.h
mozilla/gfx/src/xlib/nsGfxFactoryXlib.cpp
mozilla/gfx/src/xlib/nsPrintdXlib.h
-- snip --

I do not have a BeOS build box... I need help ...
(Assignee)

Updated

17 years ago
Keywords: helpwanted
(Assignee)

Comment 1

17 years ago
CC:'ing more BeOS folks ...
(Assignee)

Comment 2

17 years ago
Taking ...
Assignee: dcone → Roland.Mainz
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
(Assignee)

Comment 3

17 years ago
Created attachment 58897 [details]
Changes to gfx/src/xlib which need to be ported to gfx/src/beos
(Assignee)

Comment 4

17 years ago
Created attachment 58902 [details] [diff] [review]
Prototype patch
(Assignee)

Comment 5

17 years ago
Created attachment 58904 [details] [diff] [review]
Prototype patch v2
Attachment #58897 - Attachment is obsolete: true
Attachment #58902 - Attachment is obsolete: true
(Assignee)

Comment 6

17 years ago
AFAIK the attached patch should work... can someone please test it ?
Status: NEW → ASSIGNED
Keywords: patch, review
Checked in patch 2001-11-23 18:39 PDT.
(Assignee)

Comment 8

17 years ago
dbaron:
1. Thank you very much for fixing "bewildered"!
2. Can we mark this bug as FIXED ? The BeOS tinderbox isn't RED anymore - and it
was ORANGE before the landing of the new print dialog ...

Comment 9

17 years ago
I just did a checkout and built the latest tree. The new dialog seems to be OK. (it didn't crash :)
(Assignee)

Comment 10

17 years ago
Marking "FIXED" per Arougthopher's comment (comment #9).

----

Arougthopher:
It builds and does not crash - but does it work, too ?
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
No, it does not work, since printing has not been implemented on BeOS, YET.  This is on my list of todos, but there are some bug fixes that need work before that.

Comment 12

17 years ago
Roland, can you verify this and mark verified-fixed? thanks.
Status: RESOLVED → VERIFIED

Comment 13

17 years ago
oops accidentally marked verified.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Comment 14

17 years ago
marking fixed again....please verify Roland...
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

17 years ago
VERIFYING per comment #9 ...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.