1114526 - moz-elements are not updated with APNG changes, when the original element is not in the viewport

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Alberto Pastor [:albertopq]]

Not sure if this is a valid issue, or is in this way by design, but I noticed that the searching signal icon (which is an APNG) doesn't get animated on the statusbar moz-element. Only when repainting the statusbar (because of a color change, battery change, etc).

Comment 1

[Alberto Pastor [:albertopq]]

Vivien, what do you think? Should a moz-element that includes a APNG get updated on every png change?

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Test case

Note that this only happens when the original APNG is not in the the screen anymore.

Comment 3

[Alberto Pastor [:albertopq]]

So I think it probably makes sense not animating PNG or GIF (I tested, and the behavior is the same) when they are not in the screen.

Robert I've been told that you are the right person to answer this :) Is there any way to force png/gif to keep animating even if they are not in the viewport? Can we somehow keep anymating if we detect that there are observers (mozelements) pointing to that element?

Thanks!

Comment 4

[Timothy Nikkel (:tnikkel)]

From code reading I think the bug is that ImageLoader::DoRedraw uses FrameLayerBuilder::IterateRetainedDataFor to redraw after an animated image changes frames. If the image is not visible this is a no-op. But we still need to call nsSVGEffects::InvalidateDirectRenderingObservers even if the frame has no retained data and is not visible. I'll write a patch soon.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Presumably it should be easy to write a reftest for this. I'll do that next.

Comment 6

[Alberto Pastor [:albertopq]]

Works like a charm! Thanks! :)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af896e5448e6

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca6b48558b5b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/af896e5448e6

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ca6b48558b5b