1114563 - Show the room name before the user enters the room

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Once bug 1103331 is fixed and deployed on the server side, we might want to show the name of the room before the user enters it.

Comment 1

[Mark Banner (:standard8)]

Needed for the context in conversations work.

Comment 2

[Mark Banner (:standard8)]

Attachment: Show the room name before the user enters the room.

Simple patch to move the existing get call earlier in the flow - only needed for standalone, desktop manages elsewhere.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8582487 [details] [diff] [review]
Show the room name before the user enters the room.

Review of attachment 8582487 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: browser/components/loop/content/shared/js/activeRoomStore.js
@@ +181,5 @@
>          }.bind(this));
>      },
>  
>      /**
> +     * Execute fetchServerData event action from the dispatcher. For rooms

I think it's be good to keep mentioning that this method is used by the standalone client only.

@@ +215,5 @@
> +            return;
> +          }
> +
> +          this.dispatcher.dispatch(new sharedActions.UpdateRoomInfo(result));
> +      }.bind(this));

nit: please align this brace with the opening one (indentation)

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/c5bce379c537

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5bce379c537