1114568 - Add a test to check that a regular phone number should not be dialed out on the emergency dialer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/15186/

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Here's a first shot. The keypad in EmergencyCall shares the same components as the regular dialer[1] so I created a BaseKeypad class to do the same in our code. Tell me what you guys think.

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/js/dialer/keypad.js

Comment 2

[Martijn Wargers (dead)]

Comment on attachment 8542550 [details] [review]
Gaia PR

It look all right to me.

The only thing I don't really like is the switch_to_emergency_call_frame() call, but that is also already done in another test (est_lockscreen_unlock_to_emergency_call_screen.py).
I don't know if we really have a policy of where we should switch contexts, but I have the feeling that we normally do it from inside the app objects. But I may be wrong.

Comment 3

[Martijn Wargers (dead)]

Hrm, never mind, the switch_to_frame() calls are all over the place in test files.

Comment 4

[Robert Chira [:RobertC]]

Comment on attachment 8542550 [details] [review]
Gaia PR

Looks good to me. Waiting for review/feedback from Gabriele before merging.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8542550 [details] [review]
Gaia PR

Looks good to me; I like quite a bit how you managed to split the keypad class to cope both with the regular keypad as well as with the emergency one which is more limited (and I'm still waiting to fully share with the regular keypad).

Comment 6

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/5200afbd2ad00e67527b3ff451064bb0634b2821