Add a test to check that a regular phone number should not be dialed out on the emergency dialer

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
martijn.martijn
: review+
RobertC
: review+
gsvelto
: review+
Details | Review
Assignee

Updated

5 years ago
QA Whiteboard: [fxosqa-auto-s7][fxosqa-auto-points=6]
Assignee

Updated

5 years ago
Assignee: nobody → jlorenzo
Assignee

Comment 1

5 years ago
Posted file Gaia PR
Here's a first shot. The keypad in EmergencyCall shares the same components as the regular dialer[1] so I created a BaseKeypad class to do the same in our code. Tell me what you guys think.

[1] https://github.com/mozilla-b2g/gaia/blob/master/shared/js/dialer/keypad.js
Attachment #8542550 - Flags: review?(robert.chira)
Attachment #8542550 - Flags: review?(martijn.martijn)
Comment on attachment 8542550 [details] [review]
Gaia PR

It look all right to me.

The only thing I don't really like is the switch_to_emergency_call_frame() call, but that is also already done in another test (est_lockscreen_unlock_to_emergency_call_screen.py).
I don't know if we really have a policy of where we should switch contexts, but I have the feeling that we normally do it from inside the app objects. But I may be wrong.
Attachment #8542550 - Flags: review?(martijn.martijn) → review+
Hrm, never mind, the switch_to_frame() calls are all over the place in test files.
Assignee

Updated

5 years ago
Attachment #8542550 - Flags: review?(gsvelto)
Comment on attachment 8542550 [details] [review]
Gaia PR

Looks good to me. Waiting for review/feedback from Gabriele before merging.
Attachment #8542550 - Flags: review?(robert.chira) → review+
Status: NEW → ASSIGNED
Comment on attachment 8542550 [details] [review]
Gaia PR

Looks good to me; I like quite a bit how you managed to split the keypad class to cope both with the regular keypad as well as with the emergency one which is more limited (and I'm still waiting to fully share with the regular keypad).
Attachment #8542550 - Flags: review?(gsvelto) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/5200afbd2ad00e67527b3ff451064bb0634b2821
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.