Closed Bug 1114600 Opened 5 years ago Closed 5 years ago

Don't keep track of "reader enabled" state in Java

Categories

(Firefox for Android :: Reader View, defect)

35 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 37

People

(Reporter: Margaret, Assigned: Margaret)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This seems like additional cruft leftover from before we used PageActions for the reader mode button. We're passing messages and setting boolean flags that aren't necessary, so let's get rid of all that logic.
Attachment #8540167 - Flags: review?(rnewman)
/r/1621 - Bug 1114600 - Get rid of unnecessary reader enabled flag in Java

Pull down this commit:

hg pull review -r 8589526842422dea1ee7b9a0cdb29af7eea89816
I also tried moving the "toggle reader mode" logic to just be in JS instead of Java, since we're doing a pretty complicated message dance to effectively just load a new URL. However, I found that we keep track of some state in Java to avoid updating the toolbar for these reader mode transitions, so it would be non-trivial to change this, and perhaps we'll always need to keep some state in Java for controlling the reader mode UI.
Attachment #8540167 - Flags: review?(rnewman) → review+
https://reviewboard.mozilla.org/r/1619/#review1027

Hell, if this doesn't break anything, do it!
(In reply to Richard Newman [:rnewman] from comment #4)
> https://reviewboard.mozilla.org/r/1619/#review1027
> 
> Hell, if this doesn't break anything, do it!

I tested locally and couldn't find any problems, but try run for good measure:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=20c1518a8c91
https://hg.mozilla.org/mozilla-central/rev/b8e5a6a721a5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8540167 - Attachment is obsolete: true
Attachment #8618960 - Flags: review+
You need to log in before you can comment on or make changes to this bug.