1114600 - Don't keep track of "reader enabled" state in Java

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[:Margaret Leibovic]

This seems like additional cruft leftover from before we used PageActions for the reader mode button. We're passing messages and setting boolean flags that aren't necessary, so let's get rid of all that logic.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1114600/margaret

Comment 2

[:Margaret Leibovic]

/r/1621 - Bug 1114600 - Get rid of unnecessary reader enabled flag in Java

Pull down this commit:

hg pull review -r 8589526842422dea1ee7b9a0cdb29af7eea89816

Comment 3

[:Margaret Leibovic]

I also tried moving the "toggle reader mode" logic to just be in JS instead of Java, since we're doing a pretty complicated message dance to effectively just load a new URL. However, I found that we keep track of some state in Java to avoid updating the toolbar for these reader mode transitions, so it would be non-trivial to change this, and perhaps we'll always need to keep some state in Java for controlling the reader mode UI.

Comment 4

[Richard Newman [:rnewman]]

https://reviewboard.mozilla.org/r/1619/#review1027

Hell, if this doesn't break anything, do it!

Comment 5

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #4)
> https://reviewboard.mozilla.org/r/1619/#review1027
> 
> Hell, if this doesn't break anything, do it!

I tested locally and couldn't find any problems, but try run for good measure:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=20c1518a8c91

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/b8e5a6a721a5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8e5a6a721a5

Comment 9

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1114600 - Get rid of unnecessary reader enabled flag in Java