Closed
Bug 1114614
Opened 8 years ago
Closed 8 years ago
Remove nsIDownloadManagerUI from Firefox for Desktop
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 37
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
10.81 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
It turns out that we have quite a lot of dead code since we removed support for the nsIDownloadManager back-end in Firefox for Desktop. This patch deals with the simplification of nsIDownloadManagerUI. The interface is not required anymore because it is only ever called by the browser front-end itself.
Attachment #8540171 -
Flags: review?(mak77)
Comment 1•8 years ago
|
||
Comment on attachment 8540171 [details] [diff] [review] The patch Review of attachment 8540171 [details] [diff] [review]: ----------------------------------------------------------------- Awesome! ::: browser/base/content/browser.js @@ +3782,5 @@ > + "chrome,toolbar=yes,dialog=no,resizable", "Downloads"); > + } else { > + organizer.PlacesOrganizer.selectLeftPaneQuery("Downloads"); > + organizer.focus(); > + } I think instead of all of this, you can use PlacesCommandHook.showPlacesOrganizer("Downloads"); and basically convert this to a simple if/else since then you have 2 oneliners ::: browser/components/downloads/DownloadsStartup.js @@ +50,5 @@ > { > if (aTopic != "profile-after-change") { > Cu.reportError("Unexpected observer notification."); > return; > } this check is pointless, we can remove it.
Attachment #8540171 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1) > I think instead of all of this, you can use > PlacesCommandHook.showPlacesOrganizer("Downloads"); Nice! Thanks! Tryserver build before pushing to mozilla-central: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=275255915253
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a4335e10398f
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4335e10398f
Assignee: nobody → paolo.mozmail
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in
before you can comment on or make changes to this bug.
Description
•