1114639 - Autophone - Throbber stop regression 2014-12-15

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

You can see a regression beginning on fx-team on 2014-12-15 in throbber stop. On Nexus S it is on the order of 3%. It appears to be across all of the tests: local-blank, local-throbber, webappstartup.

http://phonedash.mozilla.org/#/org.mozilla.fennec/throbberstop/local-twitter/norejected/2014-12-15/2014-12-22/notcached/errorbars/standarderror

Unfortunately it is not entirely clear exactly which changeset is responsible just from the data. For local-twitter we have:

| revision                 | nexus-s | nexus-4 | nexus-5 | nexus-7 |
|--------------------------+---------+---------+---------+---------|
| fx-team/rev/8cb1ad9062cb | 6098±13 | 3925±56 | 2441±64 | 3786±23 |
| fx-team/rev/ca8735e95bad | 6181±9  | 3995±20 | 2461±50 | 3809±47 |
| fx-team/rev/97af67305dab | 6178±13 | 4141±51 | 2537±34 | 3790±53 |
| fx-team/rev/f03d296ee8dd | 6291±9  | 4158±45 | 2600±23 | 3859±43 |

https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=8cb1ad9062cb&tochange=f03d296ee8dd

Comment 1

[Bob Clary [:bc] (inactive)]

Results of testing local build on fx-team before and after Margaret's patch:

| blank     | before  | after   |
|-----------+---------+---------|
| nexus-one | 6353±14 | 6192±17 |
| galaxy s3 | 3408±26 | 3279±23 |

| twitter   | before  | after   |
|-----------+---------+---------|
| nexus-one | 7707±23 | 7489±20 |
| galaxy s3 | 4194±67 | 4318±93 |

My s3 is kind of neurotic so I would take it's results with a grain of salt. Otherwise it looks good to me.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1114639/margaret

Comment 3

[:Margaret Leibovic]

/r/2259 - Bug 1114639 - Delay initalizing DownloadNotifications

Pull down this commit:

hg pull review -r d03621c018f770ac038dcbe0185b155900383161

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/2257/#review1439

LGTM

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/b527ce325cec

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b527ce325cec

Comment 8

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1114639 - Delay initalizing DownloadNotifications