Spanish Holidays Calendar 2007-2015

RESOLVED FIXED

Status

Calendar
Website
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rickiees, Assigned: rickiees)

Tracking

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8540213 [details]
Spanish Holidays up to 2015

Spanish 2007-2015 official holidays calendar

Mozilla Calendar Project keeps in its web pages a set of national holidays calendars (.ics files). This bug provides an updated Spanish calendar (up to 2015 only, since the Spanish official holidays are defined only a few months before the next year beginning). We will be providing updates to this ics file as future official holidays happen, as this procedure has been approved upon newsgroup discussion. [1]

[1] http://groups.google.es/group/mozilla.support.calendar/msg/5e57649e9720dcd

The non-movable holidays have been redefined as a single, repeating annually, event. The current government has taken steps to relocate some holidays to the closest Monday or Friday but, as this year only days falling in Sunday have been "relocated" (thus making the recurring event not really counting as an additional holiday for the sensible user), I've decided to keep the recurring events as they are for now.
Hi Ricardo, thanks so much for the calendar. Do you think you could create a pull request against the bedrock repository?

You need to place/update the calendar file here:
https://github.com/mozilla/bedrock/tree/master/media/caldata/

and update the title here:
https://github.com/mozilla/bedrock/blob/master/media/caldata/calendars.json

If you are not familiar with github and would prefer to have someone else take care, please let me know.
(Assignee)

Comment 2

3 years ago
I've tried to do my first pull request. Haven't got any errors, but I could still have done something wrong. I'll let you to decide about that: :-)

https://github.com/mozilla/bedrock/pull/2609

Thank you for your prompt response. And, being this a bug about holidays, have Happy Holidays!
Created attachment 8540690 [details] [review]
Link to github pull request

Your pull request looks like you are a pro :-) The webdev team will take a quick look shortly and merge it, although there might be some delay due to the holidays.

Bugzilla has this link to pull request feature, not sure if its needed though. All you need to do is create an attachment, switch to being able to paste text into the attachment, then paste the link to the pull requests. I've done it with this comment.
Attachment #8540213 - Attachment is obsolete: true
Assignee: nobody → rpmdisguise-otros
Status: NEW → ASSIGNED

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e85a8e205aa08a5b8776119db521a38371717c87
Bug 1114645 - Updated Spanish Holidays Calendar for 2015

https://github.com/mozilla/bedrock/commit/9e3e95ef0d4cf384069d944e276d685fee8ddd0c
Merge pull request #2609 from RickieES/master

Bug 1114645 - Updated Spanish Holidays Calendar for 2015
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.