1114664 - Allow to carry forward r+ in reviews

Status: RESOLVED DUPLICATE of bug 1175166

(MozReview Graveyard :: General, defect, P3)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

It happens often that a patch gets r+'d, under the condition that nits and small remarks get addressed. In that case, the r+ is carried forward. In Bugzilla, when this happens, we just set r+ automatically on one of our diff file. Could we have this in ReviewBoard as well? (bonus points if we can indicate from whom we got the initial review :))

Comment 1

[Mark Côté [:mcote]]

You mean in the case that the requester uploads another patch with the nits addressed?  In that case, you'd like the r+ to stay in Bugzilla and not switch back to an r? ?

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Mark Côté [:mcote] from comment #1)
> You mean in the case that the requester uploads another patch with the nits
> addressed?  In that case, you'd like the r+ to stay in Bugzilla and not
> switch back to an r? ?

Ideally, yes.

If that is hard to achieve, I guess a substitute would be that one be able to set r+ on their own patches (so I can set r+ automatically on my patch, as a requester, after a patch obtained r+ with nits).

Comment 3

[Mark Côté [:mcote]]

We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.

Comment 4

[Mark Côté [:mcote]]

Although this is older, bug 1175166 explains this request in a bit more detail, so I'm going to dupe this over to it.