Closed Bug 1114713 Opened 9 years ago Closed 9 years ago

Intermittent test_desktop_all.py TestDesktopUnits.test_units | AssertionError: build/tests/marionette/tests/browser/components/loop/test/desktop-local/index.html: 1 failure(s) encountered | "before each" hook - timeout of 2000ms exceeded

Categories

(Hello (Loop) :: Client, defect, P2)

defect
Points:
2

Tracking

(firefox37 fixed, firefox38 fixed, firefox39 fixed, firefox-esr31 unaffected)

RESOLVED FIXED
mozilla39
Iteration:
39.1 - 9 Mar
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: standard8)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

07:12:49 INFO - TEST-START | test_desktop_all.py TestDesktopUnits.test_units
07:13:02 ERROR - TEST-UNEXPECTED-FAIL | test_desktop_all.py TestDesktopUnits.test_units | AssertionError: build/tests/marionette/tests/browser/components/loop/test/desktop-local/index.html: 1 failure(s) encountered:
07:13:02 ERROR - TEST-UNEXPECTED-FAIL | build/tests/marionette/tests/browser/components/loop/test/desktop-local/index.html | "before each" hook - timeout of 2000ms exceeded
07:13:02 INFO - timeout of 2000ms exceeded
07:13:02 INFO - done@http://localhost:2935/build/tests/marionette/tests/browser/components/loop/test/shared/vendor/mocha-2.0.1.js:4383:1
07:13:02 INFO - Runnable.prototype.run/<@http://localhost:2935/build/tests/marionette/tests/browser/components/loop/test/shared/vendor/mocha-2.0.1.js:4404:9
07:13:02 INFO - Traceback (most recent call last):
07:13:02 INFO - File "C:\slave\test\build\tests\marionette\marionette\marionette_test.py", line 268, in run
07:13:02 INFO - testMethod()
07:13:02 INFO - File "C:\slave\test\build\tests\marionette\tests\browser\components\loop\test\desktop-local\test_desktop_all.py", line 16, in test_units
07:13:02 INFO - self.check_page("index.html")
07:13:02 INFO - File "C:\slave\test\build\tests\marionette\tests\browser\components\loop\test\shared\frontend_tester.py", line 105, in check_page
07:13:02 INFO - raise AssertionError(self.get_failure_details(page))
07:13:02 INFO - TEST-INFO took 13000ms
Attached image Screen shot of failure
Ok, I managed to catch a couple of these on try server with screenshots enabled.

It appears that when the loop.panel tests run, one of them fails occasionally with a timeout in the beforeEach section.

The only reason I could see is there's a setTimeout(done, 0) at the end of the beforeEach section, that's no longer necessary.

I've got a new patch up on try server now that removes that - so we'll see how it goes.
Assignee: nobody → standard8
Iteration: --- → 39.1 - 9 Mar
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
OS: Windows XP → All
Hardware: x86 → All
Hopefully fix the intermittent. See my analysis in comment 34. I think the setTimeout was an old artefact of when the desktop side either still used the l10n.js that standalone uses, or there were some broken assumptions.

Either way, I think its safe to remove. The try run didn't show up any more failures, although they are rare-ish even with this bug, but I think we're good to go and see how it performs in the real world.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19a7f941ee2d
Attachment #8568493 - Flags: review?(mdeboer)
Attachment #8568493 - Flags: review?(mdeboer) → review+
Rank: 25
Priority: -- → P2
Comment 44 was miss-starred (the second line of the failure is different). I've filed it as bug 1137085.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: