1114825 - [EME] assertion in gmp-clearkey derefing empty std::vector

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

WriteRecordClient::OnWriteComplete in gmp-test-storage can fatally assert when reading an empty record, as it has code:

  virtual void OpenComplete(GMPErr aStatus) MOZ_OVERRIDE {
    if (GMP_SUCCEEDED(aStatus)) {
      mRecord->Write(&mData.front(), mData.size());
    } else {
      GMPRunOnMainThread(mOnFailure);
      mOnSuccess->Destroy();
    }
  }

the &mData.front() fatally asserts, when mData.size()==0.

We've already fixed this in the gmp-fake copy of the storage code.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Simple fix; don't deref an empty std::vector...

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5491c64beea

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Bustage fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ccfc23ed868

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5491c64beea
https://hg.mozilla.org/mozilla-central/rev/5ccfc23ed868

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.