Closed Bug 1114830 Opened 6 years ago Closed 6 years ago

jitters in and out of buffering mode

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

I screwed up addressing chris' review comments in bug 1109437 comment 16 and accidentally missed the key ingredient of part 7.
My plan is to wait for this try run to go green, and then land directly to m-c so that this bad behavior never ships on Nightly.
Blocks: 1114840
Landed directly to m-c: https://hg.mozilla.org/mozilla-central/rev/0532f2509f3f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8540466 [details] [diff] [review]
Only enter buffering mode when the pending request is waiting for data. v1 r=cpearce

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This does affect non-MSE playback, but is a clean and straightforward change.
[String/UUID change made/needed]: None.
Attachment #8540466 - Flags: approval-mozilla-aurora?
Attachment #8540466 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.