1114830 - jitters in and out of buffering mode

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bobby Holley (:bholley)]

I screwed up addressing chris' review comments in bug 1109437 comment 16 and accidentally missed the key ingredient of part 7.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Only enter buffering mode when the pending request is waiting for data. v1 r=cpearce

Chris r+ed this on IRC.

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=663ba79a9008

Comment 3

[Bobby Holley (:bholley)]

My plan is to wait for this try run to go green, and then land directly to m-c so that this bad behavior never ships on Nightly.

Comment 4

[Bobby Holley (:bholley)]

Landed directly to m-c: https://hg.mozilla.org/mozilla-central/rev/0532f2509f3f

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8540466 [details] [diff] [review]
Only enter buffering mode when the pending request is waiting for data. v1 r=cpearce

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This does affect non-MSE playback, but is a clean and straightforward change.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c19042e4b470