Closed Bug 1114841 Opened 5 years ago Closed 5 years ago

Deprecate DOMMMIError

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S3 (9jan)

People

(Reporter: bhsu, Assigned: bhsu)

References

Details

Attachments

(3 files, 2 obsolete files)

Once Bug 1070831 is resolved, DOMMMIError is no longer reachable. It's time to deprecate it.
Assignee: nobody → bhsu
Depends on: 1070831
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Attachment #8543722 - Flags: review?(szchen)
Attachment #8543723 - Flags: review?(szchen)
Hi Smaug,
Since DOMMMIError is going to be deprecated, a few lines in |test_interfaces.html| should be removed. Would you mind reviewing this patch?
Attachment #8543730 - Flags: review?(bugs)
Attachment #8543730 - Flags: review?(bugs) → review+
Comment on attachment 8543722 [details] [diff] [review]
Part 1: Remove DOMMMIError (WebIDL)

Review of attachment 8543722 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Let's have Hsinyi's review for webidl changes.
Attachment #8543722 - Flags: review?(szchen) → review?(htsai)
Comment on attachment 8543723 [details] [diff] [review]
Part 2: Remove DOMMMIError (DOM)

Review of attachment 8543723 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.
Attachment #8543723 - Flags: review?(szchen) → review+
Comment on attachment 8543722 [details] [diff] [review]
Part 1: Remove DOMMMIError (WebIDL)

Review of attachment 8543722 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the clean-up!
Attachment #8543722 - Flags: review?(htsai) → review+
Attachment #8543722 - Attachment is obsolete: true
Attachment #8545168 - Flags: review+
Attachment #8545168 - Attachment is obsolete: true
Attachment #8545171 - Flags: review+
You need to log in before you can comment on or make changes to this bug.