Closed Bug 1114841 Opened 10 years ago Closed 10 years ago

Deprecate DOMMMIError

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S3 (9jan)

People

(Reporter: bhsu, Assigned: bhsu)

References

Details

Attachments

(3 files, 2 obsolete files)

Part 2: Remove DOMMMIError (DOM)
4.37 KB, patch
aknow
: review+
Details | Diff | Splinter Review
Part 3: Modify the related test file
1.33 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Part 1: Remove DOMMMIError (WebIDL) (V2)
1.42 KB, patch
bhsu
: review+
Details | Diff | Splinter Review
Once Bug 1070831 is resolved, DOMMMIError is no longer reachable. It's time to deprecate it.
Assignee: nobody → bhsu
Depends on: 1070831
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Attachment #8543722 - Flags: review?(szchen)
Attachment #8543723 - Flags: review?(szchen)
Hi Smaug, Since DOMMMIError is going to be deprecated, a few lines in |test_interfaces.html| should be removed. Would you mind reviewing this patch?
Attachment #8543730 - Flags: review?(bugs)
Attachment #8543730 - Flags: review?(bugs) → review+
Comment on attachment 8543722 [details] [diff] [review] Part 1: Remove DOMMMIError (WebIDL) Review of attachment 8543722 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Let's have Hsinyi's review for webidl changes.
Attachment #8543722 - Flags: review?(szchen) → review?(htsai)
Comment on attachment 8543723 [details] [diff] [review] Part 2: Remove DOMMMIError (DOM) Review of attachment 8543723 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thank you.
Attachment #8543723 - Flags: review?(szchen) → review+
Comment on attachment 8543722 [details] [diff] [review] Part 1: Remove DOMMMIError (WebIDL) Review of attachment 8543722 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the clean-up!
Attachment #8543722 - Flags: review?(htsai) → review+
Attachment #8543722 - Attachment is obsolete: true
Attachment #8545168 - Flags: review+
Attachment #8545168 - Attachment is obsolete: true
Attachment #8545171 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: