Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Bebe, Assigned: Bebe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Add an  new test to cover regression from bug Bug 1113482

STR:
* Flash new build
* See FTU statusbar
(Assignee)

Updated

3 years ago
QA Whiteboard: [fxosqa-auto-backlog+]
(Assignee)

Comment 1

3 years ago
https://moztrap.mozilla.org/manage/cases/?filter-id=6119
(Assignee)

Comment 2

3 years ago
Created attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155
Attachment #8544591 - Flags: review?(viorela.ioia)
Attachment #8544591 - Flags: review?(jlorenzo)
(Assignee)

Updated

3 years ago
Assignee: nobody → florin.strugariu
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s7]
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155

The test works well on b2g desktop.

The main issue to me is that StatusBar should be a page region instead of a regular app. This will imply some changes in your properties. So I would refactor the StatusBar page before merging this test. What do you think?

I also found some nits lefts. More details in the PR.
Attachment #8544591 - Flags: review?(jlorenzo) → review-
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155

Looks good to me with the new changes. I think we need to precise why we don't follow exactly the steps in the manual test. This would help a future reader to understand why we just check the status bar and not all the rest. I wouldn't block on that though.
Attachment #8544591 - Flags: review- → review+
(Assignee)

Updated

3 years ago
Attachment #8544591 - Flags: review?(viorela.ioia) → review?(robert.chira)
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/b593da60cfab281c6f585f43c3aee5d65ea3acd6
Attachment #8544591 - Flags: review?(robert.chira) → review+
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.