Closed
Bug 1115026
Opened 10 years ago
Closed 10 years ago
Write test to check Bug 1113482
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Bebe, Assigned: Bebe)
Details
Attachments
(1 file)
Add an new test to cover regression from bug Bug 1113482
STR:
* Flash new build
* See FTU statusbar
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: [fxosqa-auto-backlog+]
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8544591 -
Flags: review?(viorela.ioia)
Attachment #8544591 -
Flags: review?(jlorenzo)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florin.strugariu
QA Whiteboard: [fxosqa-auto-backlog+] → [fxosqa-auto-s7]
Comment 3•10 years ago
|
||
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155
The test works well on b2g desktop.
The main issue to me is that StatusBar should be a page region instead of a regular app. This will imply some changes in your properties. So I would refactor the StatusBar page before merging this test. What do you think?
I also found some nits lefts. More details in the PR.
Attachment #8544591 -
Flags: review?(jlorenzo) → review-
Comment 4•10 years ago
|
||
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155
Looks good to me with the new changes. I think we need to precise why we don't follow exactly the steps in the manual test. This would help a future reader to understand why we just check the status bar and not all the rest. I wouldn't block on that though.
Attachment #8544591 -
Flags: review- → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8544591 -
Flags: review?(viorela.ioia) → review?(robert.chira)
Comment 5•10 years ago
|
||
Comment on attachment 8544591 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27155
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/b593da60cfab281c6f585f43c3aee5d65ea3acd6
Attachment #8544591 -
Flags: review?(robert.chira) → review+
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•