Ctrl-Tab panel's "Show all X tabs" button should read "List All X Tabs" instead

RESOLVED FIXED in Firefox 37

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: dao, Assigned: abdelrhman, Mentored)

Tracking

Trunk
Firefox 37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
The Ctrl-Tab panel (needs to be enabled via browser.ctrlTab.previews) has a "Show all X tabs" button that used to open another panel with thumbnails, but now it merely opens the "all tabs" popup. To account for that, it should say "list" rather than "show". And while we're at it, it should use title capitalization.

Abdelrhman, would you be interested in taking this bug?
(Assignee)

Comment 1

4 years ago
Created attachment 8540877 [details] [diff] [review]
rev 1 - Show all X tabs
Attachment #8540877 - Flags: review?(dao)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8540877 [details] [diff] [review]
rev 1 - Show all X tabs

I failed to explain how string changes are handled in the Mozilla code base. For this kind of change, we need to notify all non-en-US locales so that they make the same change as en-US. Just changing the en-US string value won't do that. Instead, we need to change the string id (ctrlTab.listAllTabs.label would be a good one, for instance).
Attachment #8540877 - Flags: review?(dao) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8541291 [details] [diff] [review]
rev 2 - Show all X tabs
Attachment #8541291 - Flags: review?(dao)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8541291 [details] [diff] [review]
rev 2 - Show all X tabs

Looks perfect, thanks!
Attachment #8541291 - Flags: review?(dao) → review+
(Reporter)

Updated

4 years ago
Attachment #8540877 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/bcca9f11e053
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
(Assignee)

Comment 7

4 years ago
I think you forgot to assign this bug, right?
(Reporter)

Comment 8

4 years ago
(In reply to Abdelrhman Ahmed from comment #7)
> I think you forgot to assign this bug, right?

Absolutely
Assignee: nobody → a.ahmed1026

Comment 9

3 years ago
I have reproduced this bug with Firefox Nightly 37.0a1 (Build Id : 20141223030207) on Windows 7(64-bit) with the instructions from comment 0.

Verified as fixed with Latest Firefox Nightly 46.0a1 (Build ID : 20151225030207)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

[bugday-20151223]
You need to log in before you can comment on or make changes to this bug.