1115038 - Ctrl-Tab panel's "Show all X tabs" button should read "List All X Tabs" instead

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

The Ctrl-Tab panel (needs to be enabled via browser.ctrlTab.previews) has a "Show all X tabs" button that used to open another panel with thumbnails, but now it merely opens the "all tabs" popup. To account for that, it should say "list" rather than "show". And while we're at it, it should use title capitalization.

Abdelrhman, would you be interested in taking this bug?

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - Show all X tabs

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8540877 [details] [diff] [review]
rev 1 - Show all X tabs

I failed to explain how string changes are handled in the Mozilla code base. For this kind of change, we need to notify all non-en-US locales so that they make the same change as en-US. Just changing the en-US string value won't do that. Instead, we need to change the string id (ctrlTab.listAllTabs.label would be a good one, for instance).

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 2 - Show all X tabs

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8541291 [details] [diff] [review]
rev 2 - Show all X tabs

Looks perfect, thanks!

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/bcca9f11e053

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bcca9f11e053

Comment 7

[Abdelrahman Ahmed [:abdelrahman]]

I think you forgot to assign this bug, right?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Abdelrhman Ahmed from comment #7)
> I think you forgot to assign this bug, right?

Absolutely

Comment 9

[Fahmida Noor]

I have reproduced this bug with Firefox Nightly 37.0a1 (Build Id : 20141223030207) on Windows 7(64-bit) with the instructions from comment 0.

Verified as fixed with Latest Firefox Nightly 46.0a1 (Build ID : 20151225030207)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

[bugday-20151223]