1115150 - [Homescreen][RTL] Homescreen setting menu text is not right-aligned

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Jeremiah Lee]

Attachment: homescreensettings

Description:
With RTL/Arabic enabled, the Homescreen setting menu text is not right-aligned. "Homescreen Settings", "Change Wallpaper", and "Add Smart Collections" text remain left-aligned.
   
Repro Steps:

*Change language setting to Arabic (RTL).

1) Update a Flame device to BuildID: 20141223010202
On Homescreen, long press on open area
Notice alignment of Homescreen settings menu text
  
Actual:
Homescreen setting menu text is left-aligned (RTL enabled).
  
Expected: 
Homescreen setting menu text is right-aligned (RTL enabled).
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141223010202
Gaia: c2da2bafd4e809317e2ca70c9bf5c11136a32818
Gecko: 0532f2509f3f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
  
Repro frequency: 4/4, 100%
See attached: screenshot (homescreensettings.PNG)

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1119602 to mozilla-b2g:master

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8547195 [details] [review]
[PullReq] anefzaoui:bug-1119602 to mozilla-b2g:master

Please review?
Thanks:)

Comment 3

[Chris Lord [:cwiiis]]

Comment on attachment 8547195 [details] [review]
[PullReq] anefzaoui:bug-1119602 to mozilla-b2g:master

Argh sorry, I thought I r+'d this days ago :/

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Thanks!

Comment 5

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27299

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d8e374abe4543a9975126c72fee470b049e23d1d

Comment 7

[Elie]

This issue still exist on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Reproduce rate  5/5

Description:The Homescreen setting menu text is still Left-aligned 
Refer to Attchment:VIDEO0251.mp4 and logcat.txt
Repro Steps:
1.Change synstem langua to Arabic 
2.Return to Home
3.Long press on open area to bring up  Homescreen setting menu

Actual behavior:Homescreen setting menu text is Left-aligned 
Expected behavior: Homescreen setting menu text is right-aligned

Comment 8

[Elie]

Attachment: VIDEO0251.mp4

Comment 9

[Elie]

Attachment: logcat.txt

Comment 10

[Dylan Oliver [:doliver]]

Needs uplift to 2.2

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

@Elie: please make sure that patches on master have actually landed on 2.2 before reopening a bug for 2.2. We are seeing a few cases where bugs are reopened, but it's just a matter of uplifting the patch from master to 2.2. Please take into account for next time as this creates too much noise otherwise. Thanks!
@Josh: can you make sure to communicate this out to Marigold testers please?

Comment 12

[Josh Cheng [:josh]]

Hi Elie,
Please take causion

Comment 13

[Josh Cheng [:josh]]

Hi Elie,
Please take special caution about comment 11 from Delphine. You need to check any Git commit message in comment to mark correct "tracking-b2g" flag before perform any bug work. In situation like this bug already fix in master, you should raise question to Delphine or me about whether to fix this in 2.2 since we are targeting to launch RTL in 2.2. 
Thanks

Comment 14

[Elie]

(In reply to Josh Cheng [:josh] from comment #13)
> Hi Elie,
> Please take special caution about comment 11 from Delphine. You need to
> check any Git commit message in comment to mark correct "tracking-b2g" flag
> before perform any bug work. In situation like this bug already fix in
> master, you should raise question to Delphine or me about whether to fix
> this in 2.2 since we are targeting to launch RTL in 2.2. 
> Thanks

OK ,Thanks for your reminding .

Comment 15

[Gregor Wagner [:gwagner]]

Its landed on master

Comment 16

[Gregor Wagner [:gwagner]]

Please request uplift approval here.

Comment 17

[Fabien Cazenave [:kaze]]

Comment on attachment 8547195 [details] [review]
[PullReq] anefzaoui:bug-1119602 to mozilla-b2g:master

[Approval Request Comment]
[User impact] if declined: incorrect icon alignment in the Homescreen for RTL users
[Testing completed]: manual, latest Gecko & Gaia
[Risk to taking this patch] (and alternatives if risky): none — this is a one-liner CSS change
[String changes made]: none.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f3a6f3be132b80bde10d5d0ceae08243ac5fb7ba

Comment 19

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and Master.

Result: The homescreen action menu is right-aligned in Arabic.
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150202002507
Gaia: d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko: be206fa2fb60
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
Build ID: 20150202010229
Gaia: 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko: 940118b1adcd
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0