1115211 - [RTL][Settings] Media Storage page has overlapping text

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Robert Mead [:RobertM]]

Attachment: 2014-12-23-16-10-00.png

Description:
While in an RTL language, some of the text in the media storage page is overlapping.


Repro Steps:
1) Update a Flame to 20141223010202
2) Tap 'Settings' app
3) Switch to a language that is RTL(ex: Arabic)
4) Open Media Storage page


Actual:
Some of the text is overlapping


Expected:
None of the text is overlapping


Environmental Variables:
Device: Flame 2.2(319mb)(KitKat)(Full Flash)
Build ID: 20141223010202
Gaia: c2da2bafd4e809317e2ca70c9bf5c11136a32818
Gecko: 0532f2509f3f
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Repro frequency: 100%
See attached: screenshot

Comment 1

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: demo.png

Hi @Helen,

as you can see in previous image, its `left` value is set to 1.5rem to make words overlapped together.

In this demo, I tried to set the value to 0rem in RTL case to fix this problem, but I am not sure whether this makes sense to you from visual aspect. 

Any advice / suggestion would be appreciated :)

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 4

[Helen Huang [:HHuang]]

Hi EJ, the screenshot you updated looks okay, it works for me. Thanks for the implementation.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8555744 [details] [review]
patch on master

Arthur, can you help me review this simple patch ? THanks :)

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Helen Huang from comment #4)
> Hi EJ, the screenshot you updated looks okay, it works for me. Thanks for
> the implementation.

Thanks Helen !!

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8555744 [details] [review]
patch on master

Looks good! r=me.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, landed on gaia/master : https://github.com/mozilla-b2g/gaia/commit/27f9bc5419af6b29cb8f907a5198ca39b8c3922a

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8555744 [details] [review]
patch on master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: strings would be overlapped together.
[Testing completed]: no, only one-line css change.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2b5d24d07807ae02521b47f7363600498d10001b

Comment 11

[Sue]

Attachment: screenshot.png

This issue has been verified successfully on Flame 2.2/3.0, none of the text is overlapping on Media Storage page.
STR:
1. Tap 'Settings' app.
2. Switch to a language that is RTL(ex: Arabic).
3. Open Media Storage page.
**None of the text is overlapping.
Rate:0/5

Flame 2.2 build:
Gaia-Rev        d6141fa3208f224393269e17c39d1fe53b7e6a05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f7414413e3a5
Build-ID        20150201002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.043120
FW-Date         Sun Feb  1 04:31:31 EST 2015
Bootloader      L1TC000118D0

Flame 3.0 build:
Gaia-Rev        ab69ae06a7f2b54e60ab63b1b44c8d19d5d20d94
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/c2359a6a6958
Build-ID        20150201010217
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150201.044915
FW-Date         Sun Feb  1 04:49:25 EST 2015
Bootloader      L1TC000118D0

Comment 13

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15763/