dialog for unrecognized ssl cert has vertically large buttons

VERIFIED FIXED in psm2.2

Status

Core Graveyard
Security: UI
P1
normal
VERIFIED FIXED
16 years ago
a year ago

People

(Reporter: Jeremy M. Dolan, Assigned: Rangan Sen)

Tracking

1.0 Branch
psm2.2
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments)

(Reporter)

Description

16 years ago
Modern only? Attaching screencap. Linux 2001112111.
(Reporter)

Comment 1

16 years ago
Created attachment 58912 [details]
screencap
->PSM
Assignee: mstoltz → ssaux
Component: Security: General → Client Library
Product: Browser → PSM
QA Contact: bsharma → junruh
Version: other → 2.2

Comment 3

16 years ago
rangansen
Assignee: ssaux → rangansen
Priority: -- → P1
Target Milestone: --- → 2.2
(Reporter)

Comment 4

16 years ago
Classic too.

Comment 5

16 years ago
OS->All, moving over patch from bug 112875
OS: Linux → All

Comment 6

16 years ago
Created attachment 59938 [details] [diff] [review]
Patch to correctly size buttons, add a window title

bob, javier: Could you please look at the patch, r, sr, and eventually add a
better window title before checkin?

Comment 7

16 years ago
*** Bug 112875 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 8

16 years ago
Created attachment 60096 [details] [diff] [review]
Same patch as the last one - just title changed to 'Website Certified by an Unknown Autority'

Website Certified by an Unknown Autority - might be a more apt one.
Rest of the patch seems fine.
Javi, Pl review ..

Updated

16 years ago
Keywords: patch, review

Comment 9

16 years ago
Comment on attachment 60096 [details] [diff] [review]
Same patch as the last one - just title changed to 'Website Certified by an Unknown Autority'

r=javi
Attachment #60096 - Flags: review+

Comment 10

16 years ago
I would recommend that you just convert to using the <dialog/> tag. 
dialogOverlay.xul is deprecated and all dialogs will have to be converted very soon.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 11

16 years ago
Created attachment 61173 [details] [diff] [review]
New Patch - incorporates hewitt's comments
(Assignee)

Comment 12

16 years ago
*** Bug 114484 has been marked as a duplicate of this bug. ***

Comment 13

16 years ago
Comment on attachment 61173 [details] [diff] [review]
New Patch - incorporates hewitt's comments

sr=hewitt
Attachment #61173 - Flags: superreview+
(Assignee)

Comment 14

16 years ago
Patch checked in ...
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 15

16 years ago
Verified on 12/12 Win2000 trunk.
Status: RESOLVED → VERIFIED

Updated

16 years ago
No longer blocks: 114455

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.2 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.