1115313 - [FFOS7715 v2.1][gaia][window manager][gallery]Gallery displays half of the screen when unlock.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P1)

Description

[jinchao.wang]

Description:Gallery  displays half of the screen when unlock.

Device: SPRD 7715ea

Steps to Reproduce:
1) open gallery
2）horizontal screen（landscape？）
3）press power button to lock screen on horizontal screen status
4）Vertical screen（portrait？）
5）press power button to light screen
6）unlock screen on Vertical screen status

Actual Result：Gallery displays half of the screen.

Expected Result：Gallery displays full of the screen

Repro frequency：10/10,100%

Comment 1

[jinchao.wang]

Attachment: application display only half of the screen

I has did test on Flame2.1,it has the same problem.

Comment 2

[jinchao.wang]

When reproduce, we should enable 'screen lock' first in Settings App.

Comment 3

[jinchao.wang]

This bug may because of :

Bug 1099006 - [Flame][Lock Screen]The keybord of PIN input page will be displayed on lockscreen after restart device.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Why? Regression window?

From the code I don't think so. Anyway, I would do some bisect to find out the root cause.

Comment 5

[jinchao.wang]

(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #4)
> Why? Regression window?
> 
> From the code I don't think so. Anyway, I would do some bisect to find out
> the root cause.

Dear Greg Weng:
    It prevents the spread of 'system-resize'. Video,Gallery and Browser have the same issue. Please check,thanks! I can reproduce 100% on Flame.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Yes. What I looks for is the actual root cause. The bug looks not like the root cause.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

(Of course if it is I would still fix it according the bug).

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

OK. With Alive's opinion the fix should happen at

https://github.com/mozilla-b2g/gaia/blob/v2.1/apps/system/js/layout_manager.js#L173

to remove the condition. So that every window would be re-sized.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll try the fix and to see if it works.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v2.1

The patch makes it resizing after unlocking. However, user would see the resizing transition few ms, if this is what we expect than this is a valid patch.

I now also check if v2.0 need this fix.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Well with v2.0 there is another bug occurs (orientation related, Bug 1110960). The patch is waiting approval. I may check it again after the patch landed.

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Alive: I also fix another bug only on v2.1 that breaks LockScreen too: if there is no LockScreen window been created while booting(via build variable), and then we turn it on and rotate screen with apps like Gallery or Video, user would see a broken LockScreen after pressing the power button. This is because when LockScreenWindowManager firstly create the window, the screen is still in landscape mode, so the rendering code would get wrong H/W. I patched this by adding a mozLockOrientation call before LWM create the window.

(And this only happens on v2.1).

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

[Blocking Requested - why for this release]:
Regression

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8541530 [details] [review]
Patch v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1099006 
[User impact] if declined: Gallery broken as the description
[Testing completed]:With known intermittent error: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=e7ce5af11238
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No

Comment 15

[Steven Yang [:styang]]

ni?me for reminding the uplift to 2.1S

Comment 16

[howie [:howie]]

Triage: regression blocking.

Comment 17

[bhavana bajaj [:bajaj]]

Comment on attachment 8541530 [details] [review]
Patch v2.1

Requesting QA verification once this lands on 2.1.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

v2.1:https://github.com/mozilla-b2g/gaia/commit/de6327251eb55ada67e84f1c46e4366435217099

Comment 19

[Elie]

Attachment: VIDEO0223_Compress.MP4

This issue dose not exist on Flame 2.1/2.2
Flame 2.1
Gaia-Rev        ed2e278753e8c9301ba322dcf2c3591f5928408d
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/127a0ead5f83
Build-ID        20150108001214
Version         34.0
Flame 2.2 build:
Gaia-Rev        d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/70de2960aa87
Build-ID        20150108010221
Version         37.0a1
Reproduce rate 0/10

Comment 20

[Steven Yang [:styang]]

Hi Vincent, Kai-Zhen, we will need the solution for 2.1S.

Comment 21

[Kai-Zhen Li [:seinlin][:kli]]

Bug fixed in v2.1 will get merged into v2.1s regularly.

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/127a0ead5f83