1115327 - Transition more fields of FrameMetrics to use getters/setters

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta [:kats]]

+++ This bug was initially created as a clone of Bug #1113774 +++

We are transitioning all fields of FrameMetrics to use getters/setter.

Anyone: feel free to pick one of the public fields in FrameMetrics (mScrollableRect is a good one to take), transition it, and post a patch here, flagging me for review. Thanks! See bug 1113774 for an example.

Comment 1

[Leonid V. Fedorenchik [:lvf]]

I'd like to be assigned to this bug, could someone assign me please. (Kartikaya Gupta?)

Comment 2

[Kartikaya Gupta [:kats]]

Hi Leonid,

The first step is to get Firefox building and running locally. Once you have that going I'd be happy to assign this bug to you and walk you through what needs to be done. There are instructions on how to get the Firefox code and build it at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions - let me know if you run into any problems with those.

Thanks for your interest in Mozilla and in working on this bug!

Comment 3

[Leonid V. Fedorenchik [:lvf]]

Attachment: 0001-Bug-1115327-Changed-FrameMetrics.mScrollableRect-to-.patch

Hi Kartikaya,

Thanks for your feedback. I've got Firefox Nightly built and running.

Also, looking at other similar bugs (eg. Bug #1113774), I prepared a patch for this bug; I'm sure there is something wrong, though.

Please, review and tell what need to be changed. Thanks.

Comment 4

[Kartikaya Gupta [:kats]]

Comment on attachment 8541831 [details] [diff] [review]
0001-Bug-1115327-Changed-FrameMetrics.mScrollableRect-to-.patch

Review of attachment 8541831 [details] [diff] [review]:
-----------------------------------------------------------------

This looks perfect to me, thanks for putting up the patch so quickly! I will do a push to our tryserver to make sure it builds on all platforms and then land it.

Comment 5

[Kartikaya Gupta [:kats]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d98c54851e91

Comment 6

[Kartikaya Gupta [:kats]]

Looks green, landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f980229dfc1

Comment 7

[Leonid V. Fedorenchik [:lvf]]

Thank you, Kartikaya. What should I do next to resolve this bug?

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3f980229dfc1

Comment 9

[Kartikaya Gupta [:kats]]

(In reply to Leonid V. Fedorenchik [:lvf] from comment #7)
> Thank you, Kartikaya. What should I do next to resolve this bug?

Nothing! :) The usual process is that about once a day code that lands on the integration branches (such as the inbound branch I landed your patch on) gets merged to our main "mozilla-central" branch. When that happens the bug is marked as fixed, as you can see from comment 8.

Thanks for the patch! If you'd like suggestions on what to work on next please let me know. You can look around on http://www.joshmatthews.net/bugsahoy/ to see if you can find something that matches your interests as well.

Comment 10

[Leonid V. Fedorenchik [:lvf]]

Hi Kartikaya, thank you! I want to continue to contribute to Firefox and Mozilla.
Yes, I'd love to get suggestion on what to work on next, please, could you give me advise? Also, I'd like to get to know the architecture of Firefox from developer point of view.

Comment 11

[Kartikaya Gupta [:kats]]

(In reply to Leonid V. Fedorenchik [:lvf] from comment #10)
> Hi Kartikaya, thank you! I want to continue to contribute to Firefox and
> Mozilla.
> Yes, I'd love to get suggestion on what to work on next, please, could you
> give me advise?

I listed a few bugs at https://bugzilla.mozilla.org/show_bug.cgi?id=1113774#c22 which I can mentor you through. If none of those appeal to you let me know and we can look for something else.

> Also, I'd like to get to know the architecture of Firefox
> from developer point of view.

There's lots of documentation scattered about and linked to from https://developer.mozilla.org/en-US/Firefox but honestly it's a little hard to navigate. There closest thing I can point to that it's an overall architecture overview of Firefox internals is the wiki page at https://wiki.mozilla.org/Gecko:Overview. Let me know if that's the sort of stuff you're looking for.