1115377 - Fennec updater often doesn't work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: logcat

Recently I've been seeing this happen quite often (maybe 30% of the time I try to install a downloaded update) that after I click the update notification from the android notification try it just does nothing. i.e. I get a notification for Aurora or Nightly of a new update being downloaded and ready to update, and then when I click on the notification to install the update it doesn't actually update. Or at least it doesn't pop up the updater screen the permissions and the update confirmation.

I just had this happen to me for both Nightly and Aurora and I grabbed a logcat but unfortunately it doesn't seem to show anything useful. Attaching it anyway. See start of log for when I clicked on the aurora update notification and 11:21:26 for the nightly update notification.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

I saw this today. I think maybe the service gets killed after showing the notification and we aren't handling that right.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Found a regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e90536aa55dd&tochange=df3fc7cb7e80

No interesting code changes there, but there was a blocklist update.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Wrong bug above, disregard.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

While I've never tested this thoroughly, it seemed to me like the update prompt would only open when Fennec was not in the foreground.

Comment 5

[Eugen Sawin [:esawin]]

We delete downloaded APKs on startup of the update service. The STR for this would be:
1. (Force) download the latest version (via about: page).
2. Restart Fennec.
3. Tap on the update notification.

Expected: installation starts.
Actual: nothing happens.

If Fennec does not manage to re-download the APK after step 2, we end up with a dead link in the update notification.

It is trivial to fix by moving the cleanup procedure into downloadUpdatePackage, if we are OK with having one APK around on the device, since we can't and shouldn't make networking requests on service startup.

Comment 6

[Eugen Sawin [:esawin]]

Attachment: updater-cleanup-fix

With this patch, the old APK is being deleted before downloading a new version, instead of on updater service startup.
This does leave one APK on the device, but still prevents package accumulation.

Comment 7

[Eugen Sawin [:esawin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ceeecd0186e

https://hg.mozilla.org/integration/fx-team/rev/4f5eedfd2459

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f5eedfd2459