Closed Bug 1115459 Opened 11 years ago Closed 7 years ago

Intermittent pick_test.js | Ringtone picker "before each" hook

Categories

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Ringtones
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: philor, Unassigned)

Details

(Keywords: intermittent-failure)

No description provided.
I think this is failing because of a race condition with this code: https://github.com/mozilla-b2g/gaia/blob/master/apps/ringtones/test/marionette/pick_test.js#L188-L189 Gareth: what's the proper way to fire an event in an app that Marionette can listen for? I could just wait for the text to change, but we also have a test that checks to make sure the text *hasn't* changed, and I want to make sure we're correctly testing that case too.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Flags: needinfo?(gaye)
The best way to go is probably to poll like so ```js client.waitFor(function() { return client.executeScript(function() { return readMyValue(); }); }); ``` You'll have to inject readMyValue with something like https://github.com/mozilla-b2g/gaia/tree/master/tests/jsmarionette/plugins/marionette-content-script. If you can abstract this into a generic abstraction for listening to events in jsmarionette, it would be super useful to others too.
Flags: needinfo?(gaye)
Assignee: squibblyflabbetydoo → nobody
Status: ASSIGNED → NEW
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.