Closed
Bug 1115542
Opened 10 years ago
Closed 9 years ago
Add software usage license to tests/*.java comments (except StringHelper)
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: mcomella, Assigned: san13692, Mentored)
References
Details
(Whiteboard: [lang=java][good first bug])
Attachments
(1 file)
55.69 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
StringHelper is bug 1115141.
Assignee | ||
Comment 1•10 years ago
|
||
Thanks Michael i will do it very soon..
Assignee | ||
Comment 2•9 years ago
|
||
Here's the patch please review it.
Attachment #8543135 -
Flags: review+
Updated•9 years ago
|
Attachment #8543135 -
Flags: review+ → review?(rnewman)
Updated•9 years ago
|
Component: General → Testing
Comment 3•9 years ago
|
||
Comment on attachment 8543135 [details] [diff] [review] 1115542.patch Review of attachment 8543135 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine without the modeline change. Do you want to capitalize your name in the patch metadata? ::: mobile/android/base/tests/testSearchSuggestions.java @@ -1,1 @@ > -/* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*- Don't eliminate the modeline.
Attachment #8543135 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 4•9 years ago
|
||
About name it's fine, and about that modline do i have to add it and send patch again??
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(rnewman)
Comment 5•9 years ago
|
||
Nope, I can land this with my next push.
Updated•9 years ago
|
Flags: needinfo?(rnewman)
Assignee | ||
Comment 7•9 years ago
|
||
Thanx :)
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8bda92fff8cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
Target Milestone: Firefox 37 → Firefox 38
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•