Closed Bug 1115542 Opened 5 years ago Closed 5 years ago

Add software usage license to tests/*.java comments (except StringHelper)

Categories

(Firefox for Android :: Testing, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38

People

(Reporter: mcomella, Assigned: san13692, Mentored)

References

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

Thanks Michael i will do it very soon..
Attached patch 1115542.patchSplinter Review
Here's the patch please review it.
Attachment #8543135 - Flags: review+
Attachment #8543135 - Flags: review+ → review?(rnewman)
Component: General → Testing
Comment on attachment 8543135 [details] [diff] [review]
1115542.patch

Review of attachment 8543135 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine without the modeline change.

Do you want to capitalize your name in the patch metadata?

::: mobile/android/base/tests/testSearchSuggestions.java
@@ -1,1 @@
> -/* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-

Don't eliminate the modeline.
Attachment #8543135 - Flags: review?(rnewman) → review+
About name it's fine, and about that modline do i have to add it and send patch again??
Flags: needinfo?(rnewman)
Nope, I can land this with my next push.
Flags: needinfo?(rnewman)
Thanx :)
https://hg.mozilla.org/mozilla-central/rev/8bda92fff8cb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Target Milestone: Firefox 37 → Firefox 38
You need to log in before you can comment on or make changes to this bug.